feat(bubble): migrate saved bubble charts to bubble_v2 and drop the legacy plugin - #41728
Conversation
…egacy plugin The MigrateBubbleChart processor has existed since the ECharts Bubble Chart shipped but no Alembic revision ever invoked it, so legacy nvd3 bubble charts kept rendering through explore_json. This adds the revision (with the standard MySQL MEDIUMTEXT widening and reversible form_data backups), removes the nvd3 Bubble plugin and its MainPreset registration, deletes the dead BubbleViz backend class, and strips the bubble branch from the shared NVD3 renderer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bito Automatic Review Skipped - Branch Excluded |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## remove-legacy-viz-pipeline #41728 +/- ##
==============================================================
+ Coverage 63.91% 64.70% +0.79%
==============================================================
Files 2697 2695 -2
Lines 148702 148647 -55
Branches 34331 34324 -7
==============================================================
+ Hits 95040 96188 +1148
+ Misses 51912 50699 -1213
- Partials 1750 1760 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b4a3f2e1d0c9 is the true head; the filename timestamps are not in revision order. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e viz The Life Expectancy VS Rural % example now ships as bubble_v2 so loading examples no longer recreates a legacy viz type, and the explore_json/Slice.viz integration tests exercise the still-legacy world_map slice instead (they are removed with the endpoint in the backend-removal phase). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
…egacy plugin (#41728) Co-authored-by: Claude Code <noreply@anthropic.com>
SUMMARY
Tier 3 of #41714 (targets
remove-legacy-viz-pipeline): retire the nvd3 Bubble Chart (bubble) by migrating saved charts to the ECharts Bubble Chart (bubble_v2).MigrateBubbleChartprocessor (with CLI registration and unit tests) has existed since the ECharts bubble shipped, but no Alembic revision ever invoked it — so legacy bubble charts kept rendering throughexplore_json. This PR adds the revision:d4e5f6a7b8c9, with the standard MySQL MEDIUMTEXT widening and reversibleform_data_bakbackups (same shape as the treemap/sunburst/5.0-batch migrations).legacy-preset-chart-nvd3/src/Bubble/), its MainPreset + preset registrations, the deadBubbleVizbackend class, and the bubble branch of the shared NVD3 renderer.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Saved legacy bubble charts re-open as ECharts Bubble Charts (the same auto-migration path already used for line/area/bar/dist_bar in 5.0).
TESTING INSTRUCTIONS
pytest tests/unit_tests/migrations/viz/nvd3_bubble_chart_to_echarts_test.pypasses (pre-existing processor test).npm run test -- plugins/legacy-preset-chart-nvd3passes.superset db upgradethen open a formerly-legacy bubble chart — renders asbubble_v2;superset db downgraderestores the original form_data from the backup.ADDITIONAL INFORMATION
bubbleslices (same paginated_update pattern as prior viz migrations); no downtime expected🤖 Generated with Claude Code