feat(rose): migrate rose chart to v1 chart data API

[rusackas]

SUMMARY

Tier 2 of #41714 (targets remove-legacy-viz-pipeline): migrate the Nightingale Rose Chart (rose) off explore_json onto /api/v1/chart/data.

Rose exposed the full legacy nvd3 line engine (resample, rolling windows, time comparison, contribution), so this migration leans on server-side post_processing for exact pandas semantics rather than re-implementing them in JS:

• buildQuery.ts attaches the pipeline pivot → resample → rolling → compare → contribution → flatten using the shared @superset-ui/chart-controls operators (plus a small local contribution factory, since the legacy boolean contribution control predates contributionMode), and requests time_offsets for time comparisons — the same approach the nvd3→ECharts migrations used.
• transformProps re-keys the flattened pivot records into the legacy {timestamp: [{key, value, name, time}]} shape: metric dropped from grouped single-metric keys, time-shifted (m__1 week ago) and comparison (difference__m__m__1 week ago) columns mapped to the legacy "<offset> offset" suffix, NaN collapsed to 0, series sorted by key.
• useLegacyApi: true removed.
• No DB migration: viz_type unchanged; legacy granularity_sqla/time_range handled by extractExtras.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual change — same renderer, same data shape, different endpoint.

TESTING INSTRUCTIONS

• npm run test -- plugins/legacy-plugin-chart-rose — 9 Jest tests (post-processing pipeline composition incl. rolling/resample/contribution/compare, flattened-label parsing with escaped commas, offset/comparison key mapping, NaN→0, timestamp re-keying).
• Manual: open a saved Nightingale Rose chart (incl. one with time shift / rolling window); network tab shows POST /api/v1/chart/data; rendering identical.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

[bito-code-review]

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

[bito-code-review]

The flagged issue is correct. The comparisonType value "absolute" emitted by the control panel does not match the "difference" prefix used in the backend-generated column names, causing transformData to filter out all comparison series. To resolve this, normalize the comparisonType value to "difference" before passing it to transformData in transformProps.ts.

superset-frontend/plugins/legacy-plugin-chart-rose/src/transformProps.ts

metricLabels: ensureIsArray(metrics as QueryFormMetric[]).map(
          getMetricLabel,
        ),
        timeCompare: ensureIsArray(timeCompare),
        comparisonType: comparisonType === 'absolute' ? 'difference' : comparisonType,
      })

[codecov]

Codecov Report

❌ Patch coverage is 91.35802% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.10%. Comparing base (e318607) to head (d3f490c).
⚠️ Report is 7 commits behind head on remove-legacy-viz-pipeline.

Files with missing lines	Patch %	Lines
...ins/legacy-plugin-chart-rose/src/transformProps.ts	0.00%	5 Missing ⚠️
...tend/plugins/legacy-plugin-chart-rose/src/index.ts	0.00%	1 Missing ⚠️
...gins/legacy-plugin-chart-rose/src/transformData.ts	98.33%	1 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                       @@
##           remove-legacy-viz-pipeline   #41726      +/-   ##
==============================================================
+ Coverage                       64.08%   64.10%   +0.01%     
==============================================================
  Files                            2687     2689       +2     
  Lines                          148467   148548      +81     
  Branches                        34262    34289      +27     
==============================================================
+ Hits                            95147    95221      +74     
- Misses                          51558    51565       +7     
  Partials                         1762     1762              

Flag	Coverage Δ
javascript	69.45% <91.35%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.