feat(bullet): migrate bullet chart to v1 chart data API - #41718
Merged
Conversation
Contributor
|
Bito Automatic Review Skipped - Branch Excluded |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove-legacy-viz-pipeline #41718 +/- ##
==============================================================
+ Coverage 64.62% 64.64% +0.01%
==============================================================
Files 2684 2685 +1
Lines 148431 148440 +9
Branches 34249 34252 +3
==============================================================
+ Hits 95930 95956 +26
+ Misses 50739 50722 -17
Partials 1762 1762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds a buildQuery mirroring the legacy BulletViz.query_obj (a single
ungrouped metric) and moves the {measures: [...]} reshape from the
backend get_data into the Bullet branch of the shared nvd3
transformProps. Legacy-shaped payloads pass through untouched.
No DB migration needed: viz_type is unchanged and legacy
granularity_sqla/time_range form data flows through extractExtras.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rusackas
force-pushed
the
legacy-viz-t1-bullet
branch
from
July 3, 2026 05:03
b2bbf42 to
71f153e
Compare
9 tasks
rusackas
added a commit
that referenced
this pull request
Jul 7, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 7, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 8, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 10, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 13, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 14, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 15, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 15, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 16, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 17, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 20, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 20, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 20, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 21, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 21, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 23, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas
added a commit
that referenced
this pull request
Jul 27, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Tier 1 of #41714 (targets
remove-legacy-viz-pipeline): migrate the nvd3 Bullet Chart (bullet) offexplore_jsononto/api/v1/chart/data.Bullet/buildQuery.tsmirroring the legacyBulletViz.query_obj: a single ungrouped metric.{measures: [...]}reshapeviz.pydid server-side now happens in the Bullet branch of the shared nvd3transformProps(legacy-shaped payloads pass through untouched; other nvd3 charts unaffected).useLegacyApi: trueremoved (and the "Legacy" tag dropped).viz_typeunchanged; legacygranularity_sqla/time_rangehandled byextractExtras(covered by test).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual change — same renderer, same data shape, different endpoint.
TESTING INSTRUCTIONS
npm run test -- plugins/legacy-preset-chart-nvd3— 5 new Jest tests (buildQuery shape, granularity_sqla mapping, v1 records→measures reshape incl. adhoc metric labels, legacy payload pass-through); 37 total pass.POST /api/v1/chart/data; rendering identical.ADDITIONAL INFORMATION
🤖 Generated with Claude Code