Skip to content

feat(bullet): migrate bullet chart to v1 chart data API - #41718

Merged
rusackas merged 1 commit into
remove-legacy-viz-pipelinefrom
legacy-viz-t1-bullet
Jul 3, 2026
Merged

feat(bullet): migrate bullet chart to v1 chart data API#41718
rusackas merged 1 commit into
remove-legacy-viz-pipelinefrom
legacy-viz-t1-bullet

Conversation

@rusackas

@rusackas rusackas commented Jul 3, 2026

Copy link
Copy Markdown
Member

SUMMARY

Tier 1 of #41714 (targets remove-legacy-viz-pipeline): migrate the nvd3 Bullet Chart (bullet) off explore_json onto /api/v1/chart/data.

  • New Bullet/buildQuery.ts mirroring the legacy BulletViz.query_obj: a single ungrouped metric.
  • The {measures: [...]} reshape viz.py did server-side now happens in the Bullet branch of the shared nvd3 transformProps (legacy-shaped payloads pass through untouched; other nvd3 charts unaffected).
  • useLegacyApi: true removed (and the "Legacy" tag dropped).
  • No DB migration: viz_type unchanged; legacy granularity_sqla/time_range handled by extractExtras (covered by test).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual change — same renderer, same data shape, different endpoint.

TESTING INSTRUCTIONS

  • npm run test -- plugins/legacy-preset-chart-nvd3 — 5 new Jest tests (buildQuery shape, granularity_sqla mapping, v1 records→measures reshape incl. adhoc metric labels, legacy payload pass-through); 37 total pass.
  • Manual: open a saved Bullet chart; network tab shows POST /api/v1/chart/data; rendering identical.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

@dosubot dosubot Bot added the api Related to the REST API label Jul 3, 2026
@bito-code-review

bito-code-review Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

@github-actions github-actions Bot added plugins and removed api Related to the REST API labels Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.64%. Comparing base (c6242a6) to head (71f153e).

Files with missing lines Patch % Lines
...ins/legacy-preset-chart-nvd3/src/transformProps.ts 66.66% 3 Missing ⚠️
...ugins/legacy-preset-chart-nvd3/src/Bullet/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           remove-legacy-viz-pipeline   #41718      +/-   ##
==============================================================
+ Coverage                       64.62%   64.64%   +0.01%     
==============================================================
  Files                            2684     2685       +1     
  Lines                          148431   148440       +9     
  Branches                        34249    34252       +3     
==============================================================
+ Hits                            95930    95956      +26     
+ Misses                          50739    50722      -17     
  Partials                         1762     1762              
Flag Coverage Δ
javascript 69.42% <71.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adds a buildQuery mirroring the legacy BulletViz.query_obj (a single
ungrouped metric) and moves the {measures: [...]} reshape from the
backend get_data into the Bullet branch of the shared nvd3
transformProps. Legacy-shaped payloads pass through untouched.

No DB migration needed: viz_type is unchanged and legacy
granularity_sqla/time_range form data flows through extractExtras.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@rusackas
rusackas force-pushed the legacy-viz-t1-bullet branch from b2bbf42 to 71f153e Compare July 3, 2026 05:03
@rusackas
rusackas merged commit 138f0ca into remove-legacy-viz-pipeline Jul 3, 2026
57 checks passed
@rusackas
rusackas deleted the legacy-viz-t1-bullet branch July 3, 2026 05:20
rusackas added a commit that referenced this pull request Jul 7, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 7, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 8, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 10, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 13, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 14, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 15, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 15, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 16, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 17, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 20, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 20, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 20, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 21, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 21, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 23, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
rusackas added a commit that referenced this pull request Jul 27, 2026
Co-authored-by: Claude Code <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants