chore(viz): phase 0 — remove orphaned viz.py classes and nvd3 BoxPlot leftovers

[rusackas]

SUMMARY

Phase 0 of #41714 (targets the remove-legacy-viz-pipeline feature branch): delete dead legacy-viz code that needs no migration.

• superset/viz.py: remove MapboxViz, MapLibreViz, EventFlowViz (−204 lines). None has a registered frontend: mapbox saved charts were migrated to point_cluster_map by revision ce6bd21901ab, the point_cluster_map frontend plugin has its own modern buildQuery, and event_flow's frontend was removed years ago. Bonus: with MapLibreViz gone, point_cluster_map cache warm-up flows through the v1 query-context path instead of legacy get_viz.
• legacy-preset-chart-nvd3/src/BoxPlot/: remove leftover story files — the sub-plugin is unregistered (not exported, not in MainPreset) and was superseded by the ECharts BoxPlot.
• (Not in the diff: plugins/legacy-preset-chart-deckgl/ turned out to contain zero tracked files — just a stale local node_modules/ husk.)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — dead code removal only.

TESTING INSTRUCTIONS

• ruff check superset/viz.py passes; no repo references to the removed classes remain (grep -rn "MapboxViz\|MapLibreViz\|EventFlowViz").
• pytest tests/unit_tests/test_viz_get_df_payload.py tests/unit_tests/test_viz_cache_key.py passes.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

[bito-code-review]

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

[bito-code-review]

The flagged issue is correct. Adding a gitlink (subproject pointer) for a local worktree path that is not declared in .gitmodules causes Git to treat the directory as an uninitialized submodule, which breaks repository reproducibility and can cause tooling failures. To resolve this, remove the gitlink entry and ensure the local worktree directory is ignored by Git, typically by adding it to .gitignore if it is not already there.

Based on the provided diff, the entry .claude/worktrees/ was added to .gitignore (line 9). If the gitlink was accidentally committed, you should remove the tracked gitlink from the index and ensure the directory remains untracked.

.gitignore

.claude/worktrees/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (remove-legacy-viz-pipeline@a7a8198). Learn more about missing BASE report.

Additional details and impacted files

@@                      Coverage Diff                      @@
##             remove-legacy-viz-pipeline   #41715   +/-   ##
=============================================================
  Coverage                              ?   64.62%           
=============================================================
  Files                                 ?     2684           
  Lines                                 ?   148431           
  Branches                              ?    34249           
=============================================================
  Hits                                  ?    95930           
  Misses                                ?    50739           
  Partials                              ?     1762           

Flag	Coverage Δ
hive	39.19% <ø> (?)
javascript	69.40% <ø> (?)
mysql	57.84% <ø> (?)
postgres	57.91% <ø> (?)
presto	40.73% <ø> (?)
python	59.30% <ø> (?)
sqlite	57.48% <ø> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.