chore(deps): bump sqlalchemy from 1.4.54 to 2.0.51 - #40830
chore(deps): bump sqlalchemy from 1.4.54 to 2.0.51#40830dependabot[bot] wants to merge 3 commits into
Conversation
dosubot
Bot
added
dependencies:python
risk:breaking-change
Code Review Agent Run #46b5d8Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
17dd8ca to
a3e2e61
Compare
Code Review Agent Run #da5055Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
a3e2e61 to
6119417
Compare
Code Review Agent Run #030bb0Actionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
I dug into this SA 1.4 → 2.0 bump to see how far it can be made to land safely. Short version: there is no longer a hard upstream blocker (FAB 5.x already supports SA2), but this is a real multi-PR ORM migration and isn't fully landable in one shot. I've pushed a coherent, backward-compatible prep commit ( No hard upstream dependency blockerResolving the PR's constraints (
So the historical "FAB pins SA<2" wall is gone. The work is application-code migration, not waiting on upstream. What I fixed and verified (pushed in
|
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #f8abd4
Actionable Suggestions - 1
-
superset-core/pyproject.toml - 1
- SQLAlchemy 2.0 migration incomplete · Line 49-49
Review Details
-
Files reviewed - 16 · Commit Range:
6119417..731d115- superset-core/pyproject.toml
- superset/__init__.py
- superset/commands/dataset/importers/v1/utils.py
- superset/commands/importers/v1/utils.py
- superset/common/tags.py
- superset/connectors/sqla/models.py
- superset/extensions/metadb.py
- superset/initialization/__init__.py
- superset/models/helpers.py
- superset/queries/filters.py
- superset/queries/saved_queries/filters.py
- superset/security/manager.py
- superset/utils/core.py
- superset/utils/encrypt.py
- superset/utils/mock_data.py
- tests/integration_tests/reports/commands_tests.py
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
This PR may or may not be needed in the end... there are other PRs working toward 2.0 compatability, so it's just a matter of landing planes in the right order.
|
A newer version of sqlalchemy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 1.4.54 to 2.0.50. - [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases) - [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/main/CHANGES.rst) - [Commits](https://github.com/sqlalchemy/sqlalchemy/commits) --- updated-dependencies: - dependency-name: sqlalchemy dependency-version: 2.0.50 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…on layer) Companion code changes for the SQLAlchemy 1.4 -> 2.0 bump. These are backward-compatible with SQLAlchemy 1.4 / Flask-SQLAlchemy 2.x, so they do not regress the current baseline, while unblocking the SA2 import/boot path. Mechanical SA2 breaking-change fixes: - Removed `sqlalchemy.orm.eagerload` (alias of `joinedload`) in security manager. - Legacy list-form `select([...])` -> `select(...)` and `case([...])` -> `case(...)` across runtime code (connectors, models/helpers, utils/core, extensions/metadb, common/tags, importers). - `flask_sqlalchemy.BaseQuery` removed in FSA 3.x -> import from `flask_sqlalchemy.query.Query` with a fallback to FSA 2.x. - `sqlalchemy.sql.visitors.VisitableType` removed -> `sqlalchemy.types.TypeEngine`. - Annotated Declarative: `@declared_attr` columns/relationships now require `Mapped[...]` return annotations (created_by_fk/changed_by_fk, BaseDatasource.slices); set `__allow_unmapped__` on the FAB declarative base to allow remaining legacy 1.x annotations during incremental migration. - Raw-string execution / Engine.execute removal: wrap startup health check and secrets-migrator SQL in `text()`, use a Connection, pass a single bind dict instead of **kwargs, and access Row values via `row._mapping[...]`. - Bump in-repo `apache-superset-core` SQLAlchemy pin to >=2.0.50,<3. This does not complete the full 2.0 migration. The dominant remaining blocker is SA 2.0 autobegin / connection-transaction semantics in the app/test bootstrap (FAB `_create_db` -> `Model.metadata.create_all`), plus lockfile regeneration and db_engine_spec raw-SQL execution. See the PR discussion for the full plan. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
731d115 to
53ce978
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Code Review Agent Run #e2c6d4Actionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
rusackas
changed the title
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
We'll tackle this by hand... making incremental steps on this front. |
1 participant
Bumps sqlalchemy from 1.4.54 to 2.0.50.
Release notes
Sourced from sqlalchemy's releases.
... (truncated)
Commits