fix(charts): Limit retrieval on bigquery queries from Superset - #36387
Closed
ethan-l-geotab wants to merge 2 commits into
Closed
fix(charts): Limit retrieval on bigquery queries from Superset#36387ethan-l-geotab wants to merge 2 commits into
ethan-l-geotab wants to merge 2 commits into
Conversation
ethan-l-geotab
force-pushed
the
os-partial-retvl
branch
from
December 2, 2025 23:49
02802d0 to
21ea43e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36387 +/- ##
===========================================
+ Coverage 0 67.94% +67.94%
===========================================
Files 0 637 +637
Lines 0 46913 +46913
Branches 0 5096 +5096
===========================================
+ Hits 0 31873 +31873
- Misses 0 13758 +13758
- Partials 0 1282 +1282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
we keep running into this problem, this fix would be great! |
rusackas
pushed a commit
that referenced
this pull request
Mar 11, 2026
Implement memory-aware progressive fetching in BigQuery's fetch_data method. Large result sets (950+ MB) previously crashed Chrome by loading everything into memory at once. The fix samples an initial batch to estimate row size, then fetches only as many rows as fit within the BQ_FETCH_MAX_MB config limit (default 200 MB). A warning toast is shown to users when results are truncated. This is always-on with no feature flag -- operators control the budget via the BQ_FETCH_MAX_MB config constant. Originally by @ethan-l-geotab in #36387. Co-authored-by: ethan-l-geotab <ethanliong@geotab.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
Member
|
Closing since #36385 has since been resolved as completed. If the BigQuery limit behavior still misbehaves on current master, @ethan-l-geotab, reopen with a quick repro and we'll revisit. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes: #36385
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:

after

TESTING INSTRUCTIONS
ADDITIONAL INFORMATION