fix(viz): update nesting logic to handle multiple dimensions in PartitionViz - #32290
Conversation
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
| Invalid list concatenation ▹ view | ✅ | |
| Missing dimension validation in nested structure ▹ view | ✅ |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/viz.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32290 +/- ##
===========================================
+ Coverage 60.48% 83.45% +22.96%
===========================================
Files 1931 546 -1385
Lines 76236 39101 -37135
Branches 8568 0 -8568
===========================================
- Hits 46114 32632 -13482
+ Misses 28017 6469 -21548
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kgabryje Ephemeral environment spinning up at http://34.219.203.175:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
…tionViz (apache#32290) (cherry picked from commit 6317a91)
|
I am using superset 4.1.2. I modified viz.py and viz_tests.py manually. It did not work. |

Fixes #32042
SUMMARY
Updated nest_values to support multiple dimensions, enabling correct filtering of nested properties.
ADDITIONAL INFORMATION