Skip to content

fix(viz): update nesting logic to handle multiple dimensions in PartitionViz - #32290

Merged
kgabryje merged 2 commits into
apache:masterfrom
DamianPendrak:fix-partition-chart-subcategories-with-more-than-two-dimensions
Feb 28, 2025
Merged

fix(viz): update nesting logic to handle multiple dimensions in PartitionViz#32290
kgabryje merged 2 commits into
apache:masterfrom
DamianPendrak:fix-partition-chart-subcategories-with-more-than-two-dimensions

Conversation

@DamianPendrak

Copy link
Copy Markdown
Member

Fixes #32042

SUMMARY

Updated nest_values to support multiple dimensions, enabling correct filtering of nested properties.

ADDITIONAL INFORMATION

@dosubot dosubot Bot added the viz:charts:partition Related to the Partition chart label Feb 17, 2025

@korbit-ai korbit-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Invalid list concatenation ▹ view
Functionality Missing dimension validation in nested structure ▹ view
Files scanned
File Path Reviewed
superset/viz.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Feedback and Support

Comment thread superset/viz.py Outdated
Comment thread superset/viz.py
@codecov

codecov Bot commented Feb 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.45%. Comparing base (76d897e) to head (df5a139).
⚠️ Report is 2203 commits behind head on master.

Files with missing lines Patch % Lines
superset/viz.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32290       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.96%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39101    -37135     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32632    -13482     
+ Misses      28017     6469    -21548     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.49% <0.00%> (-0.67%) ⬇️
javascript ?
mysql 75.85% <80.00%> (?)
postgres 75.92% <80.00%> (?)
presto 53.02% <0.00%> (-0.78%) ⬇️
python 83.45% <80.00%> (+19.95%) ⬆️
sqlite 75.43% <80.00%> (?)
unit 61.06% <0.00%> (+3.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pull-request-size pull-request-size Bot added size/M and removed size/S labels Feb 17, 2025
@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold! On hold labels Feb 18, 2025
@sadpandajoe
sadpandajoe requested a review from geido February 19, 2025 16:53
@geido
geido requested a review from kgabryje February 28, 2025 14:58
@github-actions

Copy link
Copy Markdown
Contributor

@kgabryje Processing your ephemeral environment request here. Action: up.

@github-actions

Copy link
Copy Markdown
Contributor

@kgabryje Ephemeral environment spinning up at http://34.219.203.175:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@kgabryje kgabryje left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this viz type, but I think it looks good 🙂

image

Code also lgtm

@kgabryje kgabryje removed the hold! On hold label Feb 28, 2025
@kgabryje
kgabryje merged commit 6317a91 into apache:master Feb 28, 2025
@michael-s-molina michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 28, 2025
michael-s-molina pushed a commit that referenced this pull request Mar 5, 2025
michael-s-molina pushed a commit that referenced this pull request Mar 5, 2025
@DamianPendrak
DamianPendrak deleted the fix-partition-chart-subcategories-with-more-than-two-dimensions branch March 8, 2025 08:41
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 21, 2025
@actocoa

actocoa commented May 26, 2025

Copy link
Copy Markdown

I am using superset 4.1.2. I modified viz.py and viz_tests.py manually. It did not work.

@mistercrunch mistercrunch added 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:bounty Issues that have been selected by Preset and have a bounty attached. size/M v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch viz:charts:partition Related to the Partition chart 🍒 5.0.0 Cherry-picked to 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partition Chart renders subcategories incorrectly when using more than two dimensions

7 participants