Skip to content

chore: Remove obsolete actor - #27147

Merged
john-bodley merged 4 commits into
masterfrom
john-bodley--remove-obsolete-actor
Feb 20, 2024
Merged

chore: Remove obsolete actor#27147
john-bodley merged 4 commits into
masterfrom
john-bodley--remove-obsolete-actor

Conversation

@john-bodley

Copy link
Copy Markdown
Member

SUMMARY

Previously, in #20499, I removed the unnecessary and now obsolete "actor" construct. It seems like I missed one instance.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions Bot added the api Related to the REST API label Feb 16, 2024
@codecov

codecov Bot commented Feb 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (1776405) to head (646bc3f).
Report is 1533 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27147      +/-   ##
==========================================
+ Coverage   67.14%   69.47%   +2.32%     
==========================================
  Files        1901     1901              
  Lines       74444    74444              
  Branches     8304     8305       +1     
==========================================
+ Hits        49989    51721    +1732     
+ Misses      22403    20670    -1733     
- Partials     2052     2053       +1     
Flag Coverage Δ
hive 53.79% <100.00%> (?)
mysql 78.00% <100.00%> (-0.01%) ⬇️
postgres 78.10% <100.00%> (-0.01%) ⬇️
presto 53.74% <100.00%> (?)
python 83.07% <100.00%> (+4.83%) ⬆️
sqlite 77.62% <100.00%> (-0.01%) ⬇️
unit 56.42% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley
john-bodley merged commit 986e417 into master Feb 20, 2024
@john-bodley
john-bodley deleted the john-bodley--remove-obsolete-actor branch February 20, 2024 20:23
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 First shipped in 4.1.0 labels Nov 27, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the REST API 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0 First shipped in 4.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants