fix(sqllab): Disable Select All on table selector - #24120
Merged
justinpark merged 1 commit intoMay 18, 2023
Conversation
justinpark
added a commit
to airbnb/superset-fork
that referenced
this pull request
May 18, 2023
Contributor
|
Not sure if this just happened very, very fast or we both coincidentally spotted the same thing but I was just coming here to raise this PR after raising a discussion about it yesterday: #24115. Thanks for fixing this. |
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
After #22084 merged, all SyncSelect has "Select All" option including a database selector. This change easily hits the tens (and can be thousands) of table preview fetches since the option triggers the preview request.
This commit disables the "Select All" option for TableSelector to resolve the issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Before:
TESTING INSTRUCTIONS
Go to SQLLab and verify that no options for "Select All" in table selector
ADDITIONAL INFORMATION