Skip to content

chore: Deprecates FilterBox - #23784

Merged
michael-s-molina merged 2 commits into
apache:masterfrom
michael-s-molina:deprecate-filter-box
Apr 24, 2023
Merged

michael-s-molina merged 2 commits into
apache:masterfrom
michael-s-molina:deprecate-filter-box

Conversation

@michael-s-molina

Copy link
Copy Markdown
Member

SUMMARY

This PR deprecates FilterBox chart by adding the necessary comments/annotations to code and modifying the plugin metadata with the (deprecated) suffix and Legacy and Deprecated tags.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-04-23 at 12 14 42

TESTING INSTRUCTIONS

Check that FilterBox is deprecated in the viz picker.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Apr 23, 2023
@codecov

codecov Bot commented Apr 23, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #23784 (1c57db0) into master (6ae5388) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1c57db0 differs from pull request most recent head 49c4879. Consider uploading reports for the commit 49c4879 to get more accurate results

@@           Coverage Diff           @@
##           master   #23784   +/-   ##
=======================================
  Coverage   67.86%   67.86%           
=======================================
  Files        1926     1926           
  Lines       74498    74500    +2     
  Branches     8108     8108           
=======================================
+ Hits        50555    50557    +2     
  Misses      21866    21866           
  Partials     2077     2077           
Flag Coverage Δ
hive 52.93% <100.00%> (+<0.01%) ⬆️
javascript 54.10% <ø> (ø)
mysql 78.67% <100.00%> (+<0.01%) ⬆️
postgres 78.75% <100.00%> (+<0.01%) ⬆️
presto 52.85% <100.00%> (+<0.01%) ⬆️
python 82.57% <100.00%> (+<0.01%) ⬆️
sqlite 77.25% <100.00%> (+<0.01%) ⬆️
unit 52.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/visualizations/FilterBox/FilterBox.jsx 49.61% <ø> (ø)
...c/visualizations/FilterBox/FilterBoxChartPlugin.js 66.66% <ø> (ø)
superset/viz.py 58.29% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
michael-s-molina merged commit 90e2b83 into apache:master Apr 24, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 First shipped in 3.0.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0 First shipped in 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants