chore: Refactor ownership

[john-bodley]

SUMMARY

A follow up to #20499 where the actor field was deprecated given this is simply the current logged in user.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21938 (4d546c7) into master (9a063ab) will increase coverage by 11.37%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #21938       +/-   ##
===========================================
+ Coverage   55.55%   66.92%   +11.37%     
===========================================
  Files        1806     1806               
  Lines       69140    69156       +16     
  Branches     7393     7393               
===========================================
+ Hits        38409    46284     +7875     
+ Misses      28822    20963     -7859     
  Partials     1909     1909               

Flag	Coverage Δ
hive	52.92% <50.00%> (+<0.01%)	⬆️
mysql	78.37% <100.00%> (?)
postgres	78.43% <100.00%> (?)
presto	52.83% <50.00%> (+<0.01%)	⬆️
python	81.49% <100.00%> (+23.54%)	⬆️
sqlite	76.92% <100.00%> (?)
unit	51.08% <50.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/datasets/api.py	87.39% <100.00%> (+38.21%)	⬆️
superset/datasets/commands/duplicate.py	90.90% <100.00%> (+61.79%)	⬆️
superset/config.py	91.69% <0.00%> (+0.63%)	⬆️
superset/views/database/views.py	31.36% <0.00%> (+0.90%)	⬆️
superset/sql_parse.py	96.49% <0.00%> (+1.16%)	⬆️
superset/db_engine_specs/__init__.py	85.71% <0.00%> (+1.19%)	⬆️
superset/tables/models.py	67.53% <0.00%> (+1.29%)	⬆️
superset/exceptions.py	90.43% <0.00%> (+1.73%)	⬆️
superset/reports/models.py	100.00% <0.00%> (+2.00%)	⬆️
superset/explore/utils.py	100.00% <0.00%> (+2.27%)	⬆️
... and 285 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[john-bodley]

This was wrong. It was passing in a List[int] whereas the class signature expected User. I'm somewhat perplexed as to why Mypy didn't report this an error. See this Slack thread for details.

[john-bodley]

See the previous comment. I gather Mypy didn't barf because it was being passed List[int] as opposed to User per the class __init__ method.

Note, per here there's no need to specify [g.user.id] given that it defaults to the current user if not specified.

[villebro]

I tried to think of any reason for this to be passed through, but couldn't come up with any valid reason, so I must assume it's not needed. And if this does indeed break something we need to add an IT for it anyway. LGTM.