Skip to content

chore(requirements): Bump trino-python-client - #20976

Merged
john-bodley merged 1 commit into
apache:masterfrom
john-bodley:john-bodley--bump-trino-python-client
Aug 4, 2022
Merged

chore(requirements): Bump trino-python-client#20976
john-bodley merged 1 commit into
apache:masterfrom
john-bodley:john-bodley--bump-trino-python-client

Conversation

@john-bodley

Copy link
Copy Markdown
Member

SUMMARY

#20729 introduces some updates to the Trino engine spec, however the Trino DB API errors were not derived from the PEP 249 error (trinodb/trino-python-client#199). This PR bumps the Trino client which includes trinodb/trino-python-client#204.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
john-bodley requested a review from ktmud August 4, 2022 16:55
@john-bodley john-bodley changed the title [requirements] Bumping trino-python-client chore(requirements): Bump trino-python-client Aug 4, 2022
@codecov

codecov Bot commented Aug 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #20976 (eef8354) into master (eb5369f) will decrease coverage by 11.49%.
The diff coverage is n/a.

❗ Current head eef8354 differs from pull request most recent head 5886256. Consider uploading reports for the commit 5886256 to get more accurate results

@@             Coverage Diff             @@
##           master   #20976       +/-   ##
===========================================
- Coverage   66.38%   54.88%   -11.50%     
===========================================
  Files        1767     1767               
  Lines       67232    67232               
  Branches     7138     7138               
===========================================
- Hits        44633    36902     -7731     
- Misses      20773    28504     +7731     
  Partials     1826     1826               
Flag Coverage Δ
hive 53.20% <ø> (ø)
mysql ?
postgres ?
presto 53.09% <ø> (ø)
python 57.84% <ø> (-23.74%) ⬇️
sqlite ?
unit 50.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
superset/views/datasource/utils.py 27.90% <0.00%> (-67.45%) ⬇️
superset/reports/commands/execute.py 25.37% <0.00%> (-66.05%) ⬇️
... and 277 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@john-bodley
john-bodley merged commit eec6e57 into apache:master Aug 4, 2022
@john-bodley
john-bodley deleted the john-bodley--bump-trino-python-client branch August 4, 2022 23:13
@cwegener

Copy link
Copy Markdown
Contributor

@john-bodley Should this also have included setup.py extra requires??

"trino": ["trino>=0.313.0"],

@mistercrunch mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants