refactor(trino): Handful of updates for the Trino engine

[john-bodley]

SUMMARY

This PR provides a number of updates for the Trino engine including:

1. Making the TrinoEngineSpec derive from the PrestoEngineSpec rather than the BaseEngineSpec. I'm not really sure as to why the later was used as it violates the DRY principle and also means that many of the Presto customizations—which Trino is forked from—were previously not defined.
2. Renames trinonative to trino—which requires a PyHive bump—thanks to @betodealmeida's work chore: rename Trino entry point dropbox/PyHive#428. I thought there was merit going forward using trino rather than trinonative everywhere.
3. Added a TrinoTemplateProcessor so macros like {{ trino.latest_partition(...) }} etc. can be used. Note made sure the processor also supported the presto key for backwards compatibility given that it is likely people will be migrating from Presto and the presto key is likely embedded in saved queries, virtual datasets, etc.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20152 (ec12b57) into master (8097403) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head ec12b57 differs from pull request most recent head d7f2ed4. Consider uploading reports for the commit d7f2ed4 to get more accurate results

@@            Coverage Diff             @@
##           master   #20152      +/-   ##
==========================================
- Coverage   66.52%   66.38%   -0.15%     
==========================================
  Files        1726     1726              
  Lines       64887    64845      -42     
  Branches     6832     6832              
==========================================
- Hits        43169    43046     -123     
- Misses      19986    20067      +81     
  Partials     1732     1732              

Flag	Coverage Δ
hive	?
mysql	82.28% <100.00%> (+0.06%)	⬆️
postgres	82.35% <100.00%> (+0.06%)	⬆️
presto	?
python	82.43% <100.00%> (-0.29%)	⬇️
sqlite	82.08% <100.00%> (+0.06%)	⬆️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/trino.py	91.93% <100.00%> (+20.50%)	⬆️
superset/jinja_context.py	91.15% <100.00%> (+0.32%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-85.19%)	⬇️
superset/db_engine_specs/hive.py	70.22% <0.00%> (-15.65%)	⬇️
superset/db_engine_specs/presto.py	83.36% <0.00%> (-5.34%)	⬇️
superset/connectors/sqla/models.py	89.05% <0.00%> (-1.19%)	⬇️
superset/initialization/__init__.py	91.13% <0.00%> (-0.36%)	⬇️
superset/db_engine_specs/base.py	88.08% <0.00%> (-0.34%)	⬇️
superset/models/core.py	88.91% <0.00%> (-0.25%)	⬇️
superset/utils/core.py	90.03% <0.00%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8097403...d7f2ed4. Read the comment docs.

[john-bodley]

I'm really not sure why these were commented out. This has always been the case since the first version of this file.

[zhaoyongjie]

Trino was forked from Presto, I think comments this is safe. thanks for keeping clear up.

[zhaoyongjie]

LGTM

[john-bodley]

Duplicate logic per line #20.

[john-bodley]

Bumping to ensure that PyHive doesn't specify the trino dialect.

[kevinwengh]

Looks like this commit broke the trino integration. Error "trino error 'Cursor' object has no attribute 'poll'" was thrown with latest docker image. There is no error just if I use docker image just before this commit.

[dungdm93]

@john-bodley, @zhaoyongjie guys. Trino engine using sqlalchemy-trino and now official trino-python-client driver. Unlike Presto and Hive which are based on PyHive.
I'm not sure make Trino inherit from PrestoEngineSpec is good or should we leave it going its own path.