Skip to content

feat(add-db): Add Big Query Form - #14700

Closed
hughhhh wants to merge 37 commits into
masterfrom
hugh/bg-form-2
Closed

feat(add-db): Add Big Query Form#14700
hughhhh wants to merge 37 commits into
masterfrom
hugh/bg-form-2

Conversation

@hughhhh

@hughhhh hughhhh commented May 18, 2021

Copy link
Copy Markdown
Member

SUMMARY

SUMMARY
Creating a big query form parameters to allow for integration with new db modal flow. Users will have a custom form to setup their big query connections. This is only the backend piece, a follow up ticket will have the frontend handling the custom form.

Dependent on #14653

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size Bot added size/M and removed size/L labels May 18, 2021
@pull-request-size pull-request-size Bot added size/L and removed size/M labels May 18, 2021
@codecov

codecov Bot commented May 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #14700 (1df008b) into master (90378ed) will increase coverage by 0.25%.
The diff coverage is 91.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14700      +/-   ##
==========================================
+ Coverage   77.31%   77.56%   +0.25%     
==========================================
  Files         959      959              
  Lines       48626    48679      +53     
  Branches     5731     5731              
==========================================
+ Hits        37593    37758     +165     
+ Misses      10832    10720     -112     
  Partials      201      201              
Flag Coverage Δ
hive 81.13% <87.50%> (?)
javascript 72.51% <ø> (ø)
mysql 81.40% <87.50%> (+0.01%) ⬆️
postgres 81.43% <91.07%> (+0.01%) ⬆️
presto 81.12% <87.50%> (?)
python 81.96% <91.07%> (+0.46%) ⬆️
sqlite 81.04% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/base.py 88.30% <50.00%> (+0.24%) ⬆️
superset/db_engine_specs/bigquery.py 94.32% <91.11%> (-1.56%) ⬇️
superset/databases/api.py 92.41% <100.00%> (ø)
superset/models/core.py 89.97% <100.00%> (+0.45%) ⬆️
superset/utils/core.py 89.02% <0.00%> (+0.12%) ⬆️
superset/connectors/sqla/models.py 90.14% <0.00%> (+1.68%) ⬆️
superset/views/database/mixins.py 82.75% <0.00%> (+1.72%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+6.94%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90378ed...1df008b. Read the comment docs.

@hughhhh hughhhh closed this May 20, 2021
@mistercrunch
mistercrunch deleted the hugh/bg-form-2 branch March 25, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant