Skip to content

[SPARK-7429] [ml] Params cleanups - #5960

Closed
jkbradley wants to merge 1 commit into
apache:masterfrom
jkbradley:params-cleanups
Closed

[SPARK-7429] [ml] Params cleanups#5960
jkbradley wants to merge 1 commit into
apache:masterfrom
jkbradley:params-cleanups

Conversation

@jkbradley

@jkbradley jkbradley commented May 7, 2015

Copy link
Copy Markdown
Member

Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does.

CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel

CC: @mengxr

@jkbradley
Params.setDefault taking a set of ParamPairs should be annotated with…
118b158 
… varargs. I thought it would not work before, but it apparently does.

CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel
@AmplabJenkins

AmplabJenkins commented May 7, 2015

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented May 7, 2015

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32067 has started for PR 5960 at commit 118b158.

@mengxr

mengxr commented May 7, 2015

Copy link
Copy Markdown
Contributor

first, others* is used to avoid overload ambiguity and empty args.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32067 has finished for PR 5960 at commit 118b158.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented May 7, 2015

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

AmplabJenkins commented May 7, 2015

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32067/
Test FAILed.

@jkbradley

jkbradley commented May 7, 2015

Copy link
Copy Markdown
Member Author

Waiting until [https://github.com//pull/5962] gets merged to test again

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #772 has started for PR 5960 at commit 118b158.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #772 has finished for PR 5960 at commit 118b158.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr

mengxr commented May 7, 2015

Copy link
Copy Markdown
Contributor

LGTM. Merged into master and branch-1.4. Thanks!

asfgit pushed a commit that referenced this pull request May 7, 2015
@jkbradley @mengxr
[SPARK-7429] [ML] Params cleanups
91ce131 
Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does.

CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #5960 from jkbradley/params-cleanups and squashes the following commits:

118b158 [Joseph K. Bradley] Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does. CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel

(cherry picked from commit 4f87e95)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 4f87e95 May 7, 2015
@jkbradley jkbradley mentioned this pull request May 9, 2015
Closed
asfgit pushed a commit that referenced this pull request May 9, 2015
@jkbradley @mengxr
[SPARK-7498] [ML] removed varargs annotation from Params.setDefaults
25972d3 
In SPARK-7429 and PR #5960, I added the varargs annotation to Params.setDefault which takes a variable number of ParamPairs. It worked locally and on Jenkins for me.
However, mengxr reported issues compiling on his machine. So I'm reverting the change introduced in #5960 by removing varargs.

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #6021 from jkbradley/revert-varargs and squashes the following commits:

098ed39 [Joseph K. Bradley] removed varargs annotation from Params.setDefaults taking multiple ParamPairs

(cherry picked from commit 2992623)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
asfgit pushed a commit that referenced this pull request May 9, 2015
@jkbradley @mengxr
[SPARK-7498] [ML] removed varargs annotation from Params.setDefaults
2992623 
In SPARK-7429 and PR #5960, I added the varargs annotation to Params.setDefault which takes a variable number of ParamPairs. It worked locally and on Jenkins for me.
However, mengxr reported issues compiling on his machine. So I'm reverting the change introduced in #5960 by removing varargs.

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #6021 from jkbradley/revert-varargs and squashes the following commits:

098ed39 [Joseph K. Bradley] removed varargs annotation from Params.setDefaults taking multiple ParamPairs
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@jkbradley @jeanlyn
[SPARK-7429] [ML] Params cleanups
1ee5303 
Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does.

CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#5960 from jkbradley/params-cleanups and squashes the following commits:

118b158 [Joseph K. Bradley] Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does. CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@jkbradley @jeanlyn
[SPARK-7498] [ML] removed varargs annotation from Params.setDefaults
ebb889b 
In SPARK-7429 and PR apache#5960, I added the varargs annotation to Params.setDefault which takes a variable number of ParamPairs. It worked locally and on Jenkins for me.
However, mengxr reported issues compiling on his machine. So I'm reverting the change introduced in apache#5960 by removing varargs.

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#6021 from jkbradley/revert-varargs and squashes the following commits:

098ed39 [Joseph K. Bradley] removed varargs annotation from Params.setDefaults taking multiple ParamPairs
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jkbradley @jeanlyn
[SPARK-7429] [ML] Params cleanups
34a56b9 
Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does.

CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#5960 from jkbradley/params-cleanups and squashes the following commits:

118b158 [Joseph K. Bradley] Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does. CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@jkbradley @jeanlyn
[SPARK-7498] [ML] removed varargs annotation from Params.setDefaults
fc188e3 
In SPARK-7429 and PR apache#5960, I added the varargs annotation to Params.setDefault which takes a variable number of ParamPairs. It worked locally and on Jenkins for me.
However, mengxr reported issues compiling on his machine. So I'm reverting the change introduced in apache#5960 by removing varargs.

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#6021 from jkbradley/revert-varargs and squashes the following commits:

098ed39 [Joseph K. Bradley] removed varargs annotation from Params.setDefaults taking multiple ParamPairs
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@jkbradley @nemccarthy
[SPARK-7429] [ML] Params cleanups
98e0b24 
Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does.

CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#5960 from jkbradley/params-cleanups and squashes the following commits:

118b158 [Joseph K. Bradley] Params.setDefault taking a set of ParamPairs should be annotated with varargs. I thought it would not work before, but it apparently does. CrossValidator.transform should call transformSchema since the underlying Model might be a PipelineModel
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@jkbradley @nemccarthy
[SPARK-7498] [ML] removed varargs annotation from Params.setDefaults
18eac0a 
In SPARK-7429 and PR apache#5960, I added the varargs annotation to Params.setDefault which takes a variable number of ParamPairs. It worked locally and on Jenkins for me.
However, mengxr reported issues compiling on his machine. So I'm reverting the change introduced in apache#5960 by removing varargs.

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#6021 from jkbradley/revert-varargs and squashes the following commits:

098ed39 [Joseph K. Bradley] removed varargs annotation from Params.setDefaults taking multiple ParamPairs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkbradley @AmplabJenkins @SparkQA @mengxr