[yanboliang]

Add a Python API for mllib.feature.ChiSqSelector
https://issues.apache.org/jira/browse/SPARK-5913

[AmplabJenkins]

Merged build triggered.

[AmplabJenkins]

Merged build started.

[SparkQA]

Test build #31973 has started for PR 5939 at commit cdaac99.

[SparkQA]

Test build #31973 has finished for PR 5939 at commit cdaac99.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class ChiSqSelectorModel(JavaVectorTransformer):
  • class ChiSqSelector(object):

[AmplabJenkins]

Merged build finished. Test PASSed.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31973/
Test PASSed.

[yanboliang]

@mengxr , @jkbradley

[jkbradley]

I'll take a look now

[jkbradley]

I don't see any issues except for documentation. Could you please make the Python docs match the Scala ones? (We've been lazy about keeping them in synch, but I want to push for Python doc parity.) Thanks!

As a follow up PR, we can finally add a Python code example to the programming guide!

[jkbradley]

Oh, also, can you please update the PR description with more details? Feel free to copy from the JIRA.

[yanboliang]

@jkbradley , I think the Python docs for ChiSqSelector and ChiSqSelectorModel have reached parity with Scala ones. Please correct me is I misunderstand.
Yes, I will add a Python code example to the programming guide in a follow up PR. We also need to check other API and add corresponding Python code examples.

[jkbradley]

@yanboliang Sorry, I just assumed the Scala doc had more content. I'll make that a to-do for later. In this case, LGTM!

For the API check, we're gradually putting together a list of the many items under this umbrella: [https://issues.apache.org/jira/browse/SPARK-7443]

Merging into master and branch-1.4

[jkbradley]

Hm, the merge script complains that this is not mergeable currently. I'll re-run the tests

[SparkQA]

Test build #788 has started for PR 5939 at commit cdaac99.

[SparkQA]

Test build #788 has finished for PR 5939 at commit cdaac99.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class ChiSqSelectorModel(JavaVectorTransformer):
  • class ChiSqSelector(object):

[jkbradley]

Weird, I'll investigate

[jkbradley]

It worked this time. Thanks!