Repository navigation
[SPARK-59918][K8S] Support deployment pods allocator in ExecutorResizePlugin - #59180
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
cc @peter-toth |
HyukjinKwon
approved these changes
Oct 1, 2026
Member
Author
|
Thank you so much, @HyukjinKwon ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Oct 1, 2026
…sizePlugin` ### What changes were proposed in this pull request? This PR aims to support `ExecutorResizePlugin` with the `deployment` pods allocator for Apache Spark 4.4.0 in addition to the default `direct` pods allocator. ### Why are the changes needed? [SPARK-56670](#55615) restricted `ExecutorResizePlugin` to the `direct` pods allocator because the higher-level controller's pod template is the source of truth for the other allocators with different mechanism. However, after SPARK-59914, Spark becomes capable of support `Deployment` because we never updates its pod template, and the `ReplicaSet` controller neither reverts in-place pod resizes nor rolls out a new revision for them. - #59175 ### Does this PR introduce _any_ user-facing change? Yes. In Apache Spark 4.2.0, `ExecutorResizePlugin` logs a warning and does not start with the `deployment` pods allocator. After this PR, it works with the `deployment` pods allocator. ### How was this patch tested? Pass the CIs with the updated test case. I also verified manually on K8s v1.37.0 that the executor pods of the `Deployment` are resized in place up to `spark.kubernetes.executor.resizeMaxMemory` without restarts, while the `Deployment` keeps its pod template and a single `ReplicaSet`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59180 from dongjoon-hyun/dongjoon/executor-resize-plugin-deployment-0e6321. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 913175e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
ExecutorResizePluginwith thedeploymentpods allocator for Apache Spark 4.4.0 in addition to the defaultdirectpods allocator.Why are the changes needed?
SPARK-56670 restricted
ExecutorResizePluginto thedirectpods allocator because the higher-level controller's pod template is the source of truth for the other allocators with different mechanism.However, after SPARK-59914, Spark becomes capable of support
Deploymentbecause we never updates its pod template, and theReplicaSetcontroller neither reverts in-place pod resizes nor rolls out a new revision for them.ExecutorResizePluginskip executor pods with the placeholderEXECIDlabel #59175Does this PR introduce any user-facing change?
Yes. In Apache Spark 4.2.0,
ExecutorResizePluginlogs a warning and does not start with thedeploymentpods allocator. After this PR, it works with thedeploymentpods allocator.How was this patch tested?
Pass the CIs with the updated test case.
I also verified manually on K8s v1.37.0 that the executor pods of the
Deploymentare resized in place up tospark.kubernetes.executor.resizeMaxMemorywithout restarts, while theDeploymentkeeps its pod template and a singleReplicaSet.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5