Skip to content

[SPARK-7328] [MLlib] [PySpark] Pyspark.mllib.linalg.Vectors: Missing items - #5872

Closed
MechCoder wants to merge 4 commits into
apache:masterfrom
MechCoder:local_linalg_api
Closed

MechCoder wants to merge 4 commits into
apache:masterfrom
MechCoder:local_linalg_api

Conversation

@MechCoder

Copy link
Copy Markdown
Contributor

Add

  1. Class methods squared_dist
  2. parse
  3. norm
  4. numNonzeros
  5. copy

I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (#5775) and plan to complete support for Matrices in another PR.

@MechCoder MechCoder changed the title [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items [SPARK-7328] [MLlib] [PySpark] Pyspark.mllib.linalg.Vectors: Missing items May 3, 2015
@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@MechCoder

Copy link
Copy Markdown
Contributor Author

ping @jkbradley @mengxr Please have a look!

@SparkQA

SparkQA commented May 3, 2015

Copy link
Copy Markdown

Test build #31699 has started for PR 5872 at commit 686b0de.

@MechCoder
MechCoder force-pushed the local_linalg_api branch from 686b0de to 350aec7 Compare May 3, 2015 17:58
@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 3, 2015

Copy link
Copy Markdown

Test build #31701 has started for PR 5872 at commit 350aec7.

@SparkQA

SparkQA commented May 3, 2015

Copy link
Copy Markdown

Test build #31701 has finished for PR 5872 at commit 350aec7.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31701/
Test FAILed.

@SparkQA

SparkQA commented May 3, 2015

Copy link
Copy Markdown

Test build #31699 has finished for PR 5872 at commit 686b0de.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31699/
Test FAILed.

@MechCoder
MechCoder force-pushed the local_linalg_api branch from 350aec7 to 59909f9 Compare May 3, 2015 19:42
@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 3, 2015

Copy link
Copy Markdown

Test build #31707 has started for PR 5872 at commit 59909f9.

@SparkQA

SparkQA commented May 3, 2015

Copy link
Copy Markdown

Test build #31707 has finished for PR 5872 at commit 59909f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31707/
Test PASSed.

@MechCoder

Copy link
Copy Markdown
Contributor Author

@mengxr Sorry for spaming but could you have a look at this too? My exams start this Friday and hence would like to complete the linalg module at least by then.

@jkbradley

Copy link
Copy Markdown
Member

I'll take a look now

Comment thread python/pyspark/mllib/linalg.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use numpy.linalg.norm(self.array, p)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@jkbradley

Copy link
Copy Markdown
Member

I just accidentally sent some comments, but I'm not done yet

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32133 has started for PR 5872 at commit 9bd269d.

@MechCoder
MechCoder force-pushed the local_linalg_api branch from 9bd269d to a8ff1e0 Compare May 7, 2015 18:33
@MechCoder

Copy link
Copy Markdown
Contributor Author

@jkbradley fixed!

@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32135 has started for PR 5872 at commit a8ff1e0.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32135 has finished for PR 5872 at commit a8ff1e0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32135/
Test FAILed.

@MechCoder

Copy link
Copy Markdown
Contributor Author

test this please

@AmplabJenkins

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32143 has started for PR 5872 at commit a8ff1e0.

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32133 has finished for PR 5872 at commit 9bd269d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32133/
Test PASSed.

@jkbradley

Copy link
Copy Markdown
Member

LGTM Merging into master and branch-1.4 Thanks!

asfgit pushed a commit that referenced this pull request May 7, 2015
…items

Add
1. Class methods squared_dist
3. parse
4. norm
5. numNonzeros
6. copy

I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (#5775) and plan to complete support for Matrices in another PR.

Author: MechCoder <manojkumarsivaraj334@gmail.com>

Closes #5872 from MechCoder/local_linalg_api and squashes the following commits:

a8ff1e0 [MechCoder] minor
ce3e53e [MechCoder] Add error message for parser
1bd3c04 [MechCoder] Robust parser and removed unnecessary methods
f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items

(cherry picked from commit 347a329)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in 347a329 May 7, 2015
@MechCoder
MechCoder deleted the local_linalg_api branch May 7, 2015 21:05
@MechCoder

Copy link
Copy Markdown
Contributor Author

Thanks! I have my exams from 8th to 18th. So will be away for a while, trying to study for those.. Just a heads up!

@jkbradley

Copy link
Copy Markdown
Member

OK, good luck with them!

@SparkQA

SparkQA commented May 7, 2015

Copy link
Copy Markdown

Test build #32143 timed out for PR 5872 at commit a8ff1e0 after a configured wait of 150m.

@AmplabJenkins

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32143/
Test FAILed.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
…items

Add
1. Class methods squared_dist
3. parse
4. norm
5. numNonzeros
6. copy

I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (apache#5775) and plan to complete support for Matrices in another PR.

Author: MechCoder <manojkumarsivaraj334@gmail.com>

Closes apache#5872 from MechCoder/local_linalg_api and squashes the following commits:

a8ff1e0 [MechCoder] minor
ce3e53e [MechCoder] Add error message for parser
1bd3c04 [MechCoder] Robust parser and removed unnecessary methods
f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
…items

Add
1. Class methods squared_dist
3. parse
4. norm
5. numNonzeros
6. copy

I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (apache#5775) and plan to complete support for Matrices in another PR.

Author: MechCoder <manojkumarsivaraj334@gmail.com>

Closes apache#5872 from MechCoder/local_linalg_api and squashes the following commits:

a8ff1e0 [MechCoder] minor
ce3e53e [MechCoder] Add error message for parser
1bd3c04 [MechCoder] Robust parser and removed unnecessary methods
f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
…items

Add
1. Class methods squared_dist
3. parse
4. norm
5. numNonzeros
6. copy

I made a few vectorizations wrt squared_dist and dot as well. I have added support for SparseMatrix serialization in a separate PR (apache#5775) and plan to complete support for Matrices in another PR.

Author: MechCoder <manojkumarsivaraj334@gmail.com>

Closes apache#5872 from MechCoder/local_linalg_api and squashes the following commits:

a8ff1e0 [MechCoder] minor
ce3e53e [MechCoder] Add error message for parser
1bd3c04 [MechCoder] Robust parser and removed unnecessary methods
f779561 [MechCoder] [SPARK-7328] Pyspark.mllib.linalg.Vectors: Missing items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants