Repository navigation
Conversation
cloud-fan
commented
Dec 24, 2025
cloud-fan
commented
Dec 24, 2025
| } | ||
| } | ||
|
|
||
| test("CTAS/RTAS should trigger two query executions") { |
Contributor
Author
There was a problem hiding this comment.
This test can pass before this PR, I'm adding it just to make sure this refactor doesn't break it and still reports two executions.
Contributor
Author
|
cc @pan3793 |
cloud-fan
commented
Dec 25, 2025
…rceV2DataFrameSuite.scala
pan3793
approved these changes
Dec 25, 2025
cloud-fan
commented
Dec 25, 2025
cloud-fan
commented
Dec 25, 2025
zhengruifeng
approved these changes
Dec 26, 2025
Contributor
|
merged to master |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 20, 2026
…ring listener in test ### What changes were proposed in this pull request? This is a followup to #53596. In the test "CTAS/RTAS should trigger two query executions", we drain the listener bus before registering the `QueryExecutionListener`, to avoid events from other tests breaking this test with unexpected `executionCount` increments. ### Why are the changes needed? Without draining the listener bus first, pending events from previous tests could fire after the listener is registered, causing flaky test failures. Other test suites follow this same pattern. ### Does this PR introduce _any_ user-facing change? No. Test-only change. ### How was this patch tested? Existing test. ### Was this patch authored or co-authored using generative AI tooling? Yes. Made with [Cursor](https://cursor.com) Closes #54397 from cloud-fan/SPARK-54835-followup. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a small refactor. In DS v2 CRAS/RTAS command, we run a nested
AppendData/OverwriteByExpressioncommand by creating aQueryExecution. ThisQueryExecutionwill create another tempQueryExecutionto eagerly execute commands. This PR avoids the unnecessary tempQueryExecutionby usingCommandExecutionMode.SKIPto createQueryExecution.Why are the changes needed?
Remove useless temp
QueryExecutionobjects.Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
cursor 2.2.43