Repository navigation
[SPARK-54148][INFRA] Add libwebp-dev to all dev/spark-test-image/*/Dockerfile - #52846
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
Could you review this PR, @LuciferYang ? |
LuciferYang
approved these changes
Nov 3, 2025
Member
Author
|
Thank you, @LuciferYang . Let me merge this to stabilize |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 3, 2025
…/Dockerfile` ### What changes were proposed in this pull request? This PR aims to add `libwebp-dev` to all `dev/spark-test-image/*/Dockerfile`. ### Why are the changes needed? Like we hit this issue before, this happens at all related docker images. - #52290 - #52838 I checked `dev` directory. - https://github.com/apache/spark/tree/branch-4.1/dev To put it simply consistent with `spark-rm/Dockerfile` behavior, we need this additionally 13 places because `libwebp-dev` is used only 3 times while `libtiff5-dev` is used 16 times. ``` $ git grep libtiff5-dev dev | wc -l 16 $ git grep libwebp-dev dev | wc -l 3 ``` ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52846 from dongjoon-hyun/SPARK-54148. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5bd5d0) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…/Dockerfile` ### What changes were proposed in this pull request? This PR aims to add `libwebp-dev` to all `dev/spark-test-image/*/Dockerfile`. ### Why are the changes needed? Like we hit this issue before, this happens at all related docker images. - apache#52290 - apache#52838 I checked `dev` directory. - https://github.com/apache/spark/tree/branch-4.1/dev To put it simply consistent with `spark-rm/Dockerfile` behavior, we need this additionally 13 places because `libwebp-dev` is used only 3 times while `libtiff5-dev` is used 16 times. ``` $ git grep libtiff5-dev dev | wc -l 16 $ git grep libwebp-dev dev | wc -l 3 ``` ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52846 from dongjoon-hyun/SPARK-54148. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Mar 17, 2026
…/Dockerfile` This PR aims to add `libwebp-dev` to all `dev/spark-test-image/*/Dockerfile`. Like we hit this issue before, this happens at all related docker images. - #52290 - #52838 I checked `dev` directory. - https://github.com/apache/spark/tree/branch-4.1/dev To put it simply consistent with `spark-rm/Dockerfile` behavior, we need this additionally 13 places because `libwebp-dev` is used only 3 times while `libtiff5-dev` is used 16 times. ``` $ git grep libtiff5-dev dev | wc -l 16 $ git grep libwebp-dev dev | wc -l 3 ``` No behavior change. Manual review. No. Closes #52846 from dongjoon-hyun/SPARK-54148. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit f5bd5d0) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d29af13) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Since this happens in branch-4.0 too Today, I backported this to branch-4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
libwebp-devto alldev/spark-test-image/*/Dockerfile.Why are the changes needed?
Like we hit this issue before, this happens at all related docker images.
libwebp-devto recoverspark-rm/Dockerfilebuilding #52290libwebp-devto fixdev/spark-test-image/lint/Dockerfilebuilding #52838I checked
devdirectory.To put it simply consistent with
spark-rm/Dockerfilebehavior, we need this additionally 13 places becauselibwebp-devis used only 3 times whilelibtiff5-devis used 16 times.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.