Repository navigation
[SPARK-6313] Add config option to disable file locks/fetchFile cache to ... - #5036
nemccarthy wants to merge 2 commits into
Conversation
…to support NFS mounts
|
Can one of the admins verify this patch? |
|
Jenkins, this is ok to test. |
|
Test build #28652 has started for PR 5036 at commit
|
|
Refer to this link for build results (access rights to CI server needed): |
|
jenkins, test this please |
|
Test build #28655 has started for PR 5036 at commit
|
|
Test build #28655 has finished for PR 5036 at commit
|
|
Test PASSed. |
|
As a workaround for the NFS issue, this looks good to me. I have a couple of minor grammar / documentation nits, which I'll comment on below, but I can fix those up myself on merge if you don't get around to it first. |
There was a problem hiding this comment.
I'd reword this slightly in order to match the style of similar boolean options. How about this:
If set to true (default), file fetching will use a local cache that is shared by executors that belong to the same application, which can improve task launching performance when running many executors on the same host. If set to false, these caching optimizations will be disabled and all executors will fetch their own copies of files. This optimization may be disabled in order to use Spark local directories that reside on NFS filesystems (see SPARK-6313 for more details).
|
@JoshRosen Thanks for the feedback. Updated as suggested. |
|
Test build #28682 has started for PR 5036 at commit
|
|
Test build #28682 has finished for PR 5036 at commit
|
|
Test PASSed. |
|
LGTM, so I'm going to merge this into |
…to ... ...support NFS mounts. This is a work around for now with the goal to find a more permanent solution. https://issues.apache.org/jira/browse/SPARK-6313 Author: nemccarthy <nathan@nemccarthy.me> Closes #5036 from nemccarthy/master and squashes the following commits: 2eaaf42 [nemccarthy] [SPARK-6313] Update config wording doc for spark.files.useFetchCache 5de7eb4 [nemccarthy] [SPARK-6313] Add config option to disable file locks/fetchFile cache to support NFS mounts (cherry picked from commit 4cca391) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
…to ... ...support NFS mounts. This is a work around for now with the goal to find a more permanent solution. https://issues.apache.org/jira/browse/SPARK-6313 Author: nemccarthy <nathan@nemccarthy.me> Closes #5036 from nemccarthy/master and squashes the following commits: 2eaaf42 [nemccarthy] [SPARK-6313] Update config wording doc for spark.files.useFetchCache 5de7eb4 [nemccarthy] [SPARK-6313] Add config option to disable file locks/fetchFile cache to support NFS mounts (cherry picked from commit 4cca391) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
...support NFS mounts.
This is a work around for now with the goal to find a more permanent solution.
https://issues.apache.org/jira/browse/SPARK-6313