Skip to content

SPARK-6225 [CORE] [SQL] [STREAMING] Resolve most build warnings, 1.3.0 edition - #4950

Closed
srowen wants to merge 2 commits into
apache:masterfrom
srowen:SPARK-6225
Closed

SPARK-6225 [CORE] [SQL] [STREAMING] Resolve most build warnings, 1.3.0 edition#4950
srowen wants to merge 2 commits into
apache:masterfrom
srowen:SPARK-6225

Conversation

@srowen

@srowen srowen commented Mar 9, 2015

Copy link
Copy Markdown
Member

Resolve javac, scalac warnings of various types -- deprecations, Scala lang, unchecked cast, etc.

@SparkQA

SparkQA commented Mar 9, 2015

Copy link
Copy Markdown

Test build #28392 has started for PR 4950 at commit c67985b.

  • This patch merges cleanly.

srowen
srowen reviewed Mar 9, 2015
View reviewed changes
Comment thread core/src/main/scala/org/apache/spark/SparkContext.scala

@srowen srowen Mar 9, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you're wondering: no this wasn't one of those things deprecated in Hadoop 2.x; this was deprecated in 1.0.4 even!

@SparkQA

SparkQA commented Mar 9, 2015

Copy link
Copy Markdown

Test build #28392 has finished for PR 4950 at commit c67985b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented Mar 9, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28392/
Test PASSed.

@tdas

tdas commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

LGTM for changes related to streaming files.

jkbradley
jkbradley reviewed Mar 9, 2015
View reviewed changes
Comment thread external/kafka/src/test/java/org/apache/spark/streaming/kafka/JavaKafkaStreamSuite.java Outdated

@jkbradley jkbradley Mar 9, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto (organize imports)

@jkbradley

jkbradley commented Mar 9, 2015

Copy link
Copy Markdown
Member

LGTM for MLlib. @srowen Thanks for taking the time to do these cleanups!

@rxin

rxin commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

lgtm

@SparkQA

SparkQA commented Mar 9, 2015

Copy link
Copy Markdown

Test build #28406 has started for PR 4950 at commit 3080972.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 9, 2015

Copy link
Copy Markdown

Test build #28406 has finished for PR 4950 at commit 3080972.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented Mar 9, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28406/
Test PASSed.

@asfgit asfgit closed this in 6e94c4e Mar 11, 2015
@srowen
srowen deleted the SPARK-6225 branch March 11, 2015 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@srowen @SparkQA @AmplabJenkins @tdas @jkbradley @rxin @marmbrus