Skip to content

[GraphX] Improve LiveJournalPageRank example - #4917

Closed
jackylk wants to merge 5 commits into
apache:masterfrom
jackylk:import
Closed

jackylk wants to merge 5 commits into
apache:masterfrom
jackylk:import

Conversation

@jackylk

@jackylk jackylk commented Mar 5, 2015

Copy link
Copy Markdown
Contributor
  1. Removed unnecessary import
  2. Modified usage print since user must specify the --numEPart parameter as it is required in Analytics.main

@SparkQA

SparkQA commented Mar 5, 2015

Copy link
Copy Markdown

Test build #28299 has started for PR 4917 at commit 5caae76.

  • This patch merges cleanly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you can remove this one? it imports implicits right?
This change loses the description of the parameter too.
This is on the border of non-trivial, but if it's merely fixing the usage note, seems OK.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it is OK.
The description of the parameter will be output by the Analytics.Main, looks like:

JackydeMacBook-Pro:spark jackylee$ bin/run-example graphx.LiveJournalPageRank ../data/Wiki-Vote.txt
Set the number of edge partitions using --numEPart.
Using Spark's default log4j profile: org/apache/spark/log4j-defaults.properties
JackydeMacBook-Pro:spark jackylee$ 

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but, why remove the description, which already existed in the help message in this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I modified back, just remove the default value description

@SparkQA

SparkQA commented Mar 5, 2015

Copy link
Copy Markdown

Test build #28299 has finished for PR 4917 at commit 5caae76.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28299/
Test PASSed.

@SparkQA

SparkQA commented Mar 6, 2015

Copy link
Copy Markdown

Test build #28319 has started for PR 4917 at commit 87be83b.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 6, 2015

Copy link
Copy Markdown

Test build #28319 has finished for PR 4917 at commit 87be83b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28319/
Test PASSed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, but now you have put the option in twice! why not just move it up and remove the square braces to mark it non-optional? keep everything else the same.

@SparkQA

SparkQA commented Mar 7, 2015

Copy link
Copy Markdown

Test build #28369 has started for PR 4917 at commit b6235e6.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 7, 2015

Copy link
Copy Markdown

Test build #28369 has finished for PR 4917 at commit b6235e6.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28369/
Test FAILed.

@SparkQA

SparkQA commented Mar 8, 2015

Copy link
Copy Markdown

Test build #28370 has started for PR 4917 at commit c0df8f2.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 8, 2015

Copy link
Copy Markdown

Test build #28370 has finished for PR 4917 at commit c0df8f2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28370/
Test FAILed.

Comment thread bin/pyspark Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but now there is this unrelated change in your PR.

@SparkQA

SparkQA commented Mar 8, 2015

Copy link
Copy Markdown

Test build #28373 has started for PR 4917 at commit 6c07682.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Mar 8, 2015

Copy link
Copy Markdown

Test build #28373 has finished for PR 4917 at commit 6c07682.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28373/
Test PASSed.

@asfgit asfgit closed this in 55b1b32 Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants