Repository navigation
Conversation
uros-db
changed the title
Contributor
|
Hi~ |
Contributor
Author
|
of course, I'll update the PR description with more details soon but shortly: as part of the collation effort in Spark, we've moved away from byte-by-byte logic towards code point per code point logic, so what we used to call UTF8_BINARY_LCASE is now UTF8_LCASE, as this describes more precisely what is going on here's a couple PRs regarding these changes: |
Contributor
got it, thanks |
Contributor
Author
|
all checks good, but several conflicts popping up adding @mkaravel @dbatomic @cloud-fan for review |
mkaravel
approved these changes
Jun 11, 2024
mkaravel
left a comment
mkaravel
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but one of the tests is failing.
Contributor
Author
|
adding @dbatomic and @cloud-fan to review |
cloud-fan
approved these changes
Jun 11, 2024
Contributor
|
thanks, merging to master! |
cloud-fan
pushed a commit
that referenced
this pull request
Jun 21, 2024
### What changes were proposed in this pull request? Re-running the collation benchmark with two modifications: - UTF8_BINARY_LCASE has been renamed to UTF8_LCASE in #46924 - UTF8_BINARY should appear first in the collation benchmark results, so performance is relative to it ### Why are the changes needed? We've changed the meaning of LCASE collation in Spark, and also modified how equality checks / hashing/ expressions work with this collation, so we need to re-run the benchmarks and identify areas of improvement. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Rxisting tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47030 from uros-db/collation-benchmarks. Authored-by: Uros Bojanic <157381213+uros-db@users.noreply.github.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Renaming
UTF8_BINARY_LCASEcollation toUTF8_LCASE.Why are the changes needed?
As part of the collation effort in Spark, we've moved away from byte-by-byte logic towards character-by-character logic, so what we used to call
UTF8_BINARY_LCASEis now more preciselyUTF8_LCASE. For example, string searching in UTF8_LCASE now works on character-level (rather than on byte-level), which is reflected in this PRs: #46511, #46589, #46682, #46761, #46762. In addition, string comparison also works on character-level now, as per the changes introduced in this PR: #46700.Does this PR introduce any user-facing change?
Yes, what was previously named
UTF8_BINARY_LCASEcollation, will from now on be namedUTF8_LCASE.How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.