Repository navigation
[SPARK-48560][SS][PYTHON] Make StreamingQueryListener.spark settable - #46909
Closed
HyukjinKwon wants to merge 4 commits into
Closed
HyukjinKwon wants to merge 4 commits into
HyukjinKwon wants to merge 4 commits into
Conversation
Contributor
|
Thanks for the fix! |
zhengruifeng
approved these changes
Jun 7, 2024
zsxwing
reviewed
Jun 7, 2024
xinrong-meng
approved these changes
Jun 7, 2024
HyukjinKwon
force-pushed
the
compat-spark-prop
branch
from
June 8, 2024 20:08
489563e to
9bd8aea
Compare
HyukjinKwon
force-pushed
the
compat-spark-prop
branch
from
June 8, 2024 20:35
9bd8aea to
562ef6f
Compare
HyukjinKwon
marked this pull request as draft
June 9, 2024 02:16
Member
Author
|
Will fix up the test |
HyukjinKwon
marked this pull request as ready for review
June 9, 2024 15:14
Member
Author
|
Merged to master. |
|
This is awesome. Thanks @HyukjinKwon . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make StreamingQueryListener.spark settable
Why are the changes needed?
is broken from 3.5.0 after SPARK-42941.
Does this PR introduce any user-facing change?
Yes, end users who implement
StreamingQueryListenercan addsparkattribute in their implementation.How was this patch tested?
Manually tested, and added a unittest.
Was this patch authored or co-authored using generative AI tooling?
No.