Repository navigation
Conversation
Contributor
Author
yaooqinn
approved these changes
Jun 7, 2024
Member
|
Thank you |
Contributor
|
@cloud-fan @yaooqinn I have submitted a PR attempt to fix it: #46912 |
Member
|
Oops, My bad, can you cherry-pick 82b4ad2 into your new PR? I just reverted this to recover the CI |
Contributor
Okay, let me to do it. |
panbingkun
pushed a commit
to panbingkun/spark
that referenced
this pull request
Jun 7, 2024
…loadTable ### What changes were proposed in this pull request? This is a followup of apache#44335 , which missed to handle `loadTable` ### Why are the changes needed? better error message ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#46905 from cloud-fan/jdbc. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
cloud-fan
added a commit
that referenced
this pull request
Jun 7, 2024
…loadTable and Fix UT ### What changes were proposed in this pull request? This is a followup of #46905, to fix `some UT` on GA. ### Why are the changes needed? Fix UT. ### Does this PR introduce _any_ user-facing change? No., ### How was this patch tested? Manually test. Pass GA ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46912 from panbingkun/SPARK-46393_FOLLOWUP. Lead-authored-by: panbingkun <panbingkun@baidu.com> Co-authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #44335 , which missed to handle
loadTableWhy are the changes needed?
better error message
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing test
Was this patch authored or co-authored using generative AI tooling?
no