Repository navigation
[SPARK-47399][SQL] Disable generated columns on expressions with collations - #45520
Closed
stefankandic wants to merge 2 commits into
Closed
stefankandic wants to merge 2 commits into
stefankandic wants to merge 2 commits into
Conversation
MaxGekk
approved these changes
Mar 15, 2024
| } | ||
| if (analyzed.exists(e => SchemaUtils.hasNonDefaultCollatedString(e.dataType))) { | ||
| throw unsupportedExpressionError( | ||
| "generation expression cannot contain non-default collated string type") |
Member
There was a problem hiding this comment.
It is not fully related to the PR, but I believe we should introduce sub-classes of UNSUPPORTED_EXPRESSION_GENERATED_COLUMN instead of the reason message paremeter.
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable the ability to use collations in expressions for generated columns.
Why are the changes needed?
Changing the collation of a column or even just changing the ICU version could lead to a differences in the resulting expression so it would be best if we simply disable it for now.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
With new unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.