Repository navigation
Conversation
…o TimestampNTZType
dongjoon-hyun
approved these changes
Mar 14, 2024
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you for making this general, @yaooqinn .
Pending CIs.
Member
Author
|
Thank you @dongjoon-hyun |
Member
|
Oh, it seems that the newly added test case fails at |
Member
|
Oh, it fails at the previous PR (SPARK-47390) instead of this PR, SPARK-47396. |
Member
Author
|
Oops...I Will check the pg time types again. The typeNames for times are copied from existing code,and they might be wrong |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 14, 2024
…esDialect ### What changes were proposed in this pull request? This PR fixes a bug in SPARK-47390, we shall separate TIME from TIMESTAMP case-match branch ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? local test with #45519 merged together ### Was this patch authored or co-authored using generative AI tooling? no Closes #45522 from yaooqinn/SPARK-47390-F. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
#45522 is merged. Could you rebase this PR to the |
Member
Author
|
Thank you very much @dongjoon-hyun |
Member
|
Merged to master for Apache Spark 4.0.0. Thank you, @yaooqinn . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a general mapping for TIME WITHOUT TIME ZONE to TimestampNTZType
Why are the changes needed?
TIME WITHOUT TIME ZONE should be able to be configured to map to TimestampNTZType like TIMESTAMP WITHOUT TIME ZONE
Does this PR introduce any user-facing change?
yes, TIME WITHOUT TIME ZONE can be mapped to TimestampNTZType when preferTimestampNTZ is true
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no