Repository navigation
Conversation
dongjoon-hyun
approved these changes
Mar 14, 2024
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
Member
Author
|
Thank you @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following the guidelines of SPARK-47375, this PR supports TIMESTAMP WITH TIME ZONE for H2Dialect and maps it to TimestampType regardless of the option
preferTimestampNTZhttps://www.h2database.com/html/datatypes.html#timestamp_with_time_zone_type
Why are the changes needed?
H2Dialect improvement, we currently don't have a default mapping for
java.sql.Types.TIME_WITH_TIMEZONE, TIMESTAMP_WITH_TIMEZONEDoes this PR introduce any user-facing change?
no
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no