Skip to content

[SPARK-47391][SQL] Remove the test case workaround for JDK 8 - #45514

Closed
beliefer wants to merge 1 commit into
apache:masterfrom
beliefer:remove-unnecessary-test
Closed

beliefer wants to merge 1 commit into
apache:masterfrom
beliefer:remove-unnecessary-test

Conversation

@beliefer

@beliefer beliefer commented Mar 14, 2024 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This PR removes the legacy test case for JDK 8 added at SPARK-34607.

Why are the changes needed?

#43080 already removed isMemberClass with class.isMemberClass.
In fact, the test case doesn't need any more.

On the other hand, this test case fails in Windows operation system.

Internal error (java.io.FileNotFoundException): D:\Users\gja\git-forks\spark\sql\catalyst\target\scala-2.13\test-classes\org\apache\spark\sql\catalyst\encoders\ExpressionEncoderSuite$OuterLevelWithVeryVeryVeryLongClassName1$OuterLevelWithVeryVeryVeryLongClassName2$OuterLevelWithVeryVeryVeryLongClassName3$OuterLevelWithVeryVeryVeryLongClassName4$OuterLevelWithVeryVeryVeryLongClassName5$OuterLevelWithVeryVeryVeryLongClassName6$.class (文件名、目录名或卷标语法不正确。)
java.io.FileNotFoundException: D:\Users\gja\git-forks\spark\sql\catalyst\target\scala-2.13\test-classes\org\apache\spark\sql\catalyst\encoders\ExpressionEncoderSuite$OuterLevelWithVeryVeryVeryLongClassName1$OuterLevelWithVeryVeryVeryLongClassName2$OuterLevelWithVeryVeryVeryLongClassName3$OuterLevelWithVeryVeryVeryLongClassName4$OuterLevelWithVeryVeryVeryLongClassName5$OuterLevelWithVeryVeryVeryLongClassName6$.class (文件名、目录名或卷标语法不正确。)
	at java.base/java.io.FileInputStream.open0(Native Method)
	at java.base/java.io.FileInputStream.open(FileInputStream.java:216)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
	at com.intellij.openapi.util.io.FileUtil.loadFileBytes(FileUtil.java:211)
	at org.jetbrains.jps.incremental.scala.local.LazyCompiledClass.$anonfun$getContent$1(LazyCompiledClass.scala:18)
	at scala.Option.getOrElse(Option.scala:201)
	at org.jetbrains.jps.incremental.scala.local.LazyCompiledClass.getContent(LazyCompiledClass.scala:17)
	at org.jetbrains.jps.incremental.instrumentation.BaseInstrumentingBuilder.performBuild(BaseInstrumentingBuilder.java:38)
	at org.jetbrains.jps.incremental.instrumentation.ClassProcessingBuilder.build(ClassProcessingBuilder.java:80)
	at org.jetbrains.jps.incremental.IncProjectBuilder.runModuleLevelBuilders(IncProjectBuilder.java:1569)
	at org.jetbrains.jps.incremental.IncProjectBuilder.runBuildersForChunk(IncProjectBuilder.java:1198)
	at org.jetbrains.jps.incremental.IncProjectBuilder.buildTargetsChunk(IncProjectBuilder.java:1349)
	at org.jetbrains.jps.incremental.IncProjectBuilder.buildChunkIfAffected(IncProjectBuilder.java:1163)
	at org.jetbrains.jps.incremental.IncProjectBuilder$BuildParallelizer$1.run(IncProjectBuilder.java:1129)
	at com.intellij.util.concurrency.BoundedTaskExecutor.doRun(BoundedTaskExecutor.java:244)
	at com.intellij.util.concurrency.BoundedTaskExecutor.access$200(BoundedTaskExecutor.java:30)
	at com.intellij.util.concurrency.BoundedTaskExecutor$1.executeFirstTaskAndHelpQueue(BoundedTaskExecutor.java:222)
	at com.intellij.util.ConcurrencyUtil.runUnderThreadName(ConcurrencyUtil.java:218)
	at com.intellij.util.concurrency.BoundedTaskExecutor$1.run(BoundedTaskExecutor.java:210)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:842)

Does this PR introduce any user-facing change?

'No'.

How was this patch tested?

N/A

Was this patch authored or co-authored using generative AI tooling?

'No'.

@github-actions github-actions Bot added the SQL label Mar 14, 2024
@beliefer beliefer changed the title [WIP][SQL] Remove the test case workaround for JDK 8 [SPARK-47391][SQL] Remove the test case workaround for JDK 8 Mar 14, 2024
@beliefer

Copy link
Copy Markdown
Contributor Author

@yaooqinn

Copy link
Copy Markdown
Member

Is this test case still valid for determining if there is a lurking JDK bug?

@beliefer

beliefer commented Mar 14, 2024 •

Copy link
Copy Markdown
Contributor Author

Is this test case still valid for determining if there is a lurking JDK bug?

It's invalid. Because the bug belongs to JDK8. After JDK9, the bug fixed.

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM from my side. Thank you, @beliefer .

@dongjoon-hyun

Copy link
Copy Markdown
Member

Merged to master for Apache Spark 4.0.0.

Thank you, @beliefer and @yaooqinn .

@LuciferYang

Copy link
Copy Markdown
Contributor

late LGTM

@beliefer

Copy link
Copy Markdown
Contributor Author

@dongjoon-hyun @yaooqinn @LuciferYang Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants