Skip to content

[SPARK-47390][SQL] PostgresDialect distinguishes TIMESTAMP from TIMESTAMP_TZ - #45513

Closed
yaooqinn wants to merge 2 commits into
apache:masterfrom
yaooqinn:SPARK-47390
Closed

yaooqinn wants to merge 2 commits into
apache:masterfrom
yaooqinn:SPARK-47390

Conversation

@yaooqinn

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Regarding SPARK-47375, this PR fixes the issue of converting PG TIMESTAMP_TZ & TIME_TZ to our NTZ.

Why are the changes needed?

bugfix

Does this PR introduce any user-facing change?

yes, as 3.5 is out, this PR add a migration guide for this.

How was this patch tested?

new tests

Was this patch authored or co-authored using generative AI tooling?

mo

@yaooqinn

Copy link
Copy Markdown
Member Author

cc @cloud-fan @dongjoon-hyun, thanks.

@yaooqinn yaooqinn closed this in 336801d Mar 14, 2024
@yaooqinn
yaooqinn deleted the SPARK-47390 branch March 14, 2024 11:47
@yaooqinn

Copy link
Copy Markdown
Member Author

Merged to master.

Thank you for the review @cloud-fan

// See SPARK-34333 and https://github.com/pgjdbc/pgjdbc/issues/100
Some(StringType)
case Types.TIMESTAMP
if "timestamptz".equalsIgnoreCase(typeName) || "timetz".equalsIgnoreCase(typeName) =>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45522 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants