Repository navigation
[SPARK-47375][Doc][FollowUp] Fix a mistake in JDBC's preferTimestampNTZ option doc - #45510
Closed
gengliangwang wants to merge 2 commits into
Closed
gengliangwang wants to merge 2 commits into
gengliangwang wants to merge 2 commits into
Conversation
yaooqinn
reviewed
Mar 14, 2024
| When the option is set to <code>true</code>, TIMESTAMP WITHOUT TIME ZONE type are inferred as Spark's TimestampNTZ type. | ||
| Otherwise, it is interpreted as Spark's Timestamp type(equivalent to TIMESTAMP WITHOUT LOCAL TIME ZONE). | ||
| This setting specifically affects only the inference of TIMESTAMP WITHOUT TIME ZONE data type. Both TIMESTAMP WITHOUT LOCAL TIME ZONE and TIMESTAMP WITH TIME ZONE data types are consistently interpreted as Spark's Timestamp type regardless of this setting. | ||
| Otherwise, it is interpreted as Spark's Timestamp type(equivalent to TIMESTAMP WITH LOCAL TIME ZONE). |
Member
There was a problem hiding this comment.
typo in L371 are inferred -> is inferred
yaooqinn
approved these changes
Mar 14, 2024
HyukjinKwon
approved these changes
Mar 14, 2024
Member
|
It seems that we missed |
Member
|
Merged to master. Thank you @gengliangwang @HyukjinKwon |
yaooqinn
pushed a commit
that referenced
this pull request
Mar 14, 2024
…TZ option doc ### What changes were proposed in this pull request? Fix a mistake in JDBC's preferTimestampNTZ option doc ### Why are the changes needed? Fix a mistake in doc ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Just doc change ### Was this patch authored or co-authored using generative AI tooling? No Closes #45510 from gengliangwang/reviseJdbcDoc. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 63b79c1) Signed-off-by: Kent Yao <yao@apache.org>
yaooqinn
pushed a commit
that referenced
this pull request
Mar 14, 2024
…TZ option doc ### What changes were proposed in this pull request? Fix a mistake in JDBC's preferTimestampNTZ option doc ### Why are the changes needed? Fix a mistake in doc ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Just doc change ### Was this patch authored or co-authored using generative AI tooling? No Closes #45510 from gengliangwang/reviseJdbcDoc. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 63b79c1) Signed-off-by: Kent Yao <yao@apache.org>
Member
|
Added to branch-3.4/3.5 too, according #45502 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a mistake in JDBC's preferTimestampNTZ option doc
Why are the changes needed?
Fix a mistake in doc
Does this PR introduce any user-facing change?
No
How was this patch tested?
Just doc change
Was this patch authored or co-authored using generative AI tooling?
No