Repository navigation
[Don't Merge] upgrade sbt 1.9.8 - #44516
panbingkun wants to merge 15 commits into
Conversation
panbingkun
changed the title
| } | ||
| ) | ||
|
|
||
| lazy val cachePolicies = if (sys.env.contains("SKIP_LOCAL_M2")) { |
There was a problem hiding this comment.
If this is necessary, this work should be completed in a separate PR first.
There was a problem hiding this comment.
Okay, Let me try this solution first 😄
|
I changed my approach and modified some of the logic in Friendly ping @dongjoon-hyun, |
| Resolver.file("ivyLocal", file(Path.userHome.absolutePath + "/.ivy2/local"))(Resolver.ivyStylePatterns) | ||
| ), | ||
| DefaultMavenRepository) ++ | ||
| { if (sys.env.contains("SKIP_LOCAL_M2")) Nil else Seq(Resolver.mavenLocal) } :+ |
There was a problem hiding this comment.
Main modification points.
panbingkun
changed the title
| PYSPARK_DRIVER_PYTHON: python3.9 | ||
| PYSPARK_PYTHON: python3.9 | ||
| GITHUB_PREV_SHA: ${{ github.event.before }} | ||
| SKIP_LOCAL_M2: true |
There was a problem hiding this comment.
Only for Linters, licenses, dependencies and documentation generation
|
PTAL when you have some time, and Happy New Year 😄. @dongjoon-hyun |
|
Thank you for your deep investigation, @panbingkun . Happy New Year. |
|
If SBT does not provide any improvement, we may need to stick to the old SBT version. |
Okay, let's continue to observe |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
has an offline discussion with @LuciferYang, another approach maybe: Should we ignore This bug in |
3 participants
What changes were proposed in this pull request?
The pr aims to upgrade sbt from
1.9.3to1.9.8.Why are the changes needed?
After version sbt 1.9.3, if there are corrupt jars under the local (~/. m2), some workflows will fail to compile. Based on this, we added an environment variable (
SKIP_LOCAL_M2) in SparkBuild to control whether to use theMaven Local Resolvermechanism.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.