Skip to content

[SPARK-4882] Register PythonBroadcast with Kryo so that PySpark works with KryoSerializer - #3831

Closed
JoshRosen wants to merge 3 commits into
apache:masterfrom
JoshRosen:SPARK-4882
Closed

JoshRosen wants to merge 3 commits into
apache:masterfrom
JoshRosen:SPARK-4882

Conversation

@JoshRosen

Copy link
Copy Markdown
Contributor

This PR fixes an issue where PySpark broadcast variables caused NullPointerExceptions if KryoSerializer was used. The fix is to register PythonBroadcast with Kryo so that it's deserialized with a KryoJavaSerializer.

@SparkQA

SparkQA commented Dec 29, 2014

Copy link
Copy Markdown

Test build #24868 has started for PR 3831 at commit 0466c7a.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Dec 29, 2014

Copy link
Copy Markdown

Test build #24868 has finished for PR 3831 at commit 0466c7a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24868/
Test PASSed.

@davies

davies commented Dec 29, 2014

Copy link
Copy Markdown
Contributor

LGTM, thanks for fixing it!

asfgit pushed a commit that referenced this pull request Dec 30, 2014
… with KryoSerializer

This PR fixes an issue where PySpark broadcast variables caused NullPointerExceptions if KryoSerializer was used.  The fix is to register PythonBroadcast with Kryo so that it's deserialized with a KryoJavaSerializer.

Author: Josh Rosen <joshrosen@databricks.com>

Closes #3831 from JoshRosen/SPARK-4882 and squashes the following commits:

0466c7a [Josh Rosen] Register PythonBroadcast with Kryo.
d5b409f [Josh Rosen] Enable registrationRequired, which would have caught this bug.
069d8a7 [Josh Rosen] Add failing test for SPARK-4882

(cherry picked from commit efa80a5)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@asfgit asfgit closed this in efa80a5 Dec 30, 2014
asfgit pushed a commit that referenced this pull request Dec 30, 2014
… with KryoSerializer

This PR fixes an issue where PySpark broadcast variables caused NullPointerExceptions if KryoSerializer was used.  The fix is to register PythonBroadcast with Kryo so that it's deserialized with a KryoJavaSerializer.

Author: Josh Rosen <joshrosen@databricks.com>

Closes #3831 from JoshRosen/SPARK-4882 and squashes the following commits:

0466c7a [Josh Rosen] Register PythonBroadcast with Kryo.
d5b409f [Josh Rosen] Enable registrationRequired, which would have caught this bug.
069d8a7 [Josh Rosen] Add failing test for SPARK-4882

(cherry picked from commit efa80a5)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@JoshRosen

Copy link
Copy Markdown
Contributor Author

I've merged this into master (1.3.0) and branch-1.2 (1.2.1).

@JoshRosen
JoshRosen deleted the SPARK-4882 branch December 30, 2014 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants