Repository navigation
Conversation
HyukjinKwon
reviewed
Aug 22, 2022
HyukjinKwon
left a comment
HyukjinKwon
left a comment
Member
There was a problem hiding this comment.
@caican00 mind creating a JIRA, and fix the PR title? See also https://spark.apache.org/contributing.html.
Also, we should probably fix it in the master branch instead of branch-3.3. Otherwise, looks pretty good
Contributor
Author
thanks, i will close this pr and open a new pr to master branch |
caican00
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Traversable.toMapchanged tocollections.breakOut, that eliminates intermediate tuple collection creation.I optimized it with reference to this pr:#18693
An introduction to
Collections. BreakOutcan be found at Stack Overflow article.Why are the changes needed?
When
DeserializeToObjectis executed, converting Tuple2 to Scala Map via. ToMaptakes a lot of cpu time.How was this patch tested?
Unit tests run.
No performance tests performed yet.