Repository navigation
Conversation
Member
Author
|
@HyukjinKwon Please, take a look at this follow up PR. I addressed @cloud-fan 's comments from #29912 (comment) |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #129456 has finished for PR 29957 at commit
|
HyukjinKwon
approved these changes
Oct 7, 2020
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Get error message from the expected exception, and check that they are reasonable.
Why are the changes needed?
To improve tests by expecting particular error messages.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running
JDBCTableCatalogSuite.