Skip to content

[SPARK-30196][BUILD] Bump lz4-java version to 1.7.0 - #26823

Closed
maropu wants to merge 2 commits into
apache:masterfrom
maropu:LZ4_1_7_0
Closed

[SPARK-30196][BUILD] Bump lz4-java version to 1.7.0#26823
maropu wants to merge 2 commits into
apache:masterfrom
maropu:LZ4_1_7_0

Conversation

@maropu

@maropu maropu commented Dec 9, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This pr intends to upgrade lz4-java from 1.6.0 to 1.7.0.

Why are the changes needed?

This release includes a performance bug (lz4/lz4-java#143) fixed by @JoshRosen and some improvements (e.g., LZ4 binary update). You can see the link below for the changes;
https://github.com/lz4/lz4-java/blob/master/CHANGES.md#170

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests.

@maropu

maropu commented Dec 9, 2019

Copy link
Copy Markdown
Member Author

cc: @JoshRosen @dongjoon-hyun @srowen

@SparkQA

SparkQA commented Dec 10, 2019

Copy link
Copy Markdown

Test build #115056 has finished for PR 26823 at commit 87f2474.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen

Copy link
Copy Markdown
Contributor

@maropu, it looks like you need to run:

./dev/test-dependencies.sh --replace-manifest

to update the dependency manifests.

Thanks for submitting this PR!

Comment thread pom.xml
<groupId>org.lz4</groupId>
<artifactId>lz4-java</artifactId>
<version>1.6.0</version>
<version>1.7.0</version>

@dongjoon-hyun dongjoon-hyun Dec 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the dependency files with dev/test-dependencies.sh --replace-manifest? I missed @JoshRosen 's comment.

@maropu

maropu commented Dec 10, 2019

Copy link
Copy Markdown
Member Author

oh, I forgot to do so, thanks! I'll update soon.

@kiszk

kiszk commented Dec 10, 2019

Copy link
Copy Markdown
Member

LGTM, pending Jenkins

@HyukjinKwon HyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@SparkQA

SparkQA commented Dec 10, 2019

Copy link
Copy Markdown

Test build #115057 has finished for PR 26823 at commit 0fb7efe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

Copy link
Copy Markdown
Member

Merged to master.

@maropu

maropu commented Dec 10, 2019

Copy link
Copy Markdown
Member Author

Thanks, all.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants