Skip to content

[SPARK-3771][SQL] AppendingParquetOutputFormat should use reflection to prevent from breaking binary-compatibility. #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 2 commits into from
Closed

[SPARK-3771][SQL] AppendingParquetOutputFormat should use reflection to prevent from breaking binary-compatibility. #2638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec213c1
Use reflection to prevent breaking binary-compatibility.
ueshin Oct 2, 2014
efd3784
Add a comment to explain the reason to use reflection.
ueshin Oct 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,13 +331,21 @@ private[parquet] class AppendingParquetOutputFormat(offset: Int)

// override to choose output filename so not overwrite existing ones
override def getDefaultWorkFile(context: TaskAttemptContext, extension: String): Path = {
val taskId: TaskID = context.getTaskAttemptID.getTaskID
val taskId: TaskID = getTaskAttemptID(context).getTaskID
val partition: Int = taskId.getId
val filename = s"part-r-${partition + offset}.parquet"
val committer: FileOutputCommitter =
getOutputCommitter(context).asInstanceOf[FileOutputCommitter]
new Path(committer.getWorkPath, filename)
}

// The TaskAttemptContext is a class in hadoop-1 but is an interface in hadoop-2.
// The signatures of the method TaskAttemptContext.getTaskAttemptID for the both versions
// are the same, so the method calls are source-compatible but NOT binary-compatible because
// the opcode of method call for class is INVOKEVIRTUAL and for interface is INVOKEINTERFACE.
private def getTaskAttemptID(context: TaskAttemptContext): TaskAttemptID = {
context.getClass.getMethod("getTaskAttemptID").invoke(context).asInstanceOf[TaskAttemptID]
}
}

/**
Expand Down