Repository navigation
Conversation
…uick solution to this is to not go a level up incase we are in the root rather than root/core/. If we are in the root everything works fine, if we are in core add a script which goes and runs the level up
|
Note: set -x is intentionally left in so that during the build it is clear which R source is being built. |
| </executions> | ||
| <configuration> | ||
| <executable>..${file.separator}R${file.separator}install-dev${script.extension}</executable> | ||
| <executable>${file.separator}R${file.separator}install-dev${script.extension}</executable> |
There was a problem hiding this comment.
would it work if this is
<executable>${project.basedir}${file.separator}..${file.separator}R${file.separator}install-dev${script.extension}</executable>
|
That should work more simply, thanks. I'll try that later on tonight. |
|
Test build #82355 has finished for PR 19402 at commit
|
|
@felixcheung can you trigger the R tests for this? |
|
Test build #82356 has finished for PR 19402 at commit
|
|
I'm not sure why appveyor is not triggered... |
|
building your change here #19403 |
|
passed |
|
Sounds good :) |
| </executions> | ||
| <configuration> | ||
| <executable>..${file.separator}R${file.separator}install-dev${script.extension}</executable> | ||
| <executable>${project.basedir}${file.separator}..${file.separator}R${file.separator}install-dev${script.extension}</executable> |
There was a problem hiding this comment.
Looks this tab is inserted mistakenly BTW.
## What changes were proposed in this pull request? When zinc is running the pwd might be in the root of the project. A quick solution to this is to not go a level up incase we are in the root rather than root/core/. If we are in the root everything works fine, if we are in core add a script which goes and runs the level up ## How was this patch tested? set -x in the SparkR install scripts. Author: Holden Karau <holden@us.ibm.com> Closes #19402 from holdenk/SPARK-22167-sparkr-packaging-issue-allow-zinc. (cherry picked from commit 8fab799) Signed-off-by: Holden Karau <holden@us.ibm.com>
## What changes were proposed in this pull request? When zinc is running the pwd might be in the root of the project. A quick solution to this is to not go a level up incase we are in the root rather than root/core/. If we are in the root everything works fine, if we are in core add a script which goes and runs the level up ## How was this patch tested? set -x in the SparkR install scripts. Author: Holden Karau <holden@us.ibm.com> Closes #19402 from holdenk/SPARK-22167-sparkr-packaging-issue-allow-zinc. (cherry picked from commit 8fab799) Signed-off-by: Holden Karau <holden@us.ibm.com>
|
merged to master, branch-2.2, and branch-2.1 |
|
Test build #82393 has finished for PR 19402 at commit
|
## What changes were proposed in this pull request? When zinc is running the pwd might be in the root of the project. A quick solution to this is to not go a level up incase we are in the root rather than root/core/. If we are in the root everything works fine, if we are in core add a script which goes and runs the level up ## How was this patch tested? set -x in the SparkR install scripts. Author: Holden Karau <holden@us.ibm.com> Closes apache#19402 from holdenk/SPARK-22167-sparkr-packaging-issue-allow-zinc. (cherry picked from commit 8fab799) Signed-off-by: Holden Karau <holden@us.ibm.com>
What changes were proposed in this pull request?
When zinc is running the pwd might be in the root of the project. A quick solution to this is to not go a level up incase we are in the root rather than root/core/. If we are in the root everything works fine, if we are in core add a script which goes and runs the level up
How was this patch tested?
set -x in the SparkR install scripts.