Repository navigation
Conversation
|
@polarke , can you please provide the details of how you tested this? |
|
@polarke : |
srowen
approved these changes
Jul 30, 2017
srowen
left a comment
srowen
left a comment
Member
There was a problem hiding this comment.
@remisharoon in this case I don't think a screenshot is needed. The nature of the change is clear from the diff. I think the change is OK.
|
Test build #3862 has finished for PR 18774 at commit
|
HyukjinKwon
approved these changes
Jul 30, 2017
HyukjinKwon
left a comment
HyukjinKwon
left a comment
Member
There was a problem hiding this comment.
I double checked and it looks okay to me too.
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In programming guide,
numTasksis used in several places as arguments of Transformations. However, in code,numPartitionsis used. In this fix, I replacenumTaskswithnumPartitionsin programming guide for consistency.