RATIS-2133. Include netty-proxy-handler dependency in the project.#53
RATIS-2133. Include netty-proxy-handler dependency in the project.#53sadanand48 wants to merge 1 commit intoapache:masterfrom
Conversation
|
@adoroszlai, Could you please review? |
|
Thanks @sadanand48 for the patch. Shouldn't Ratis avoid using proxy for gRPC/Netty? HTTP proxy is usually for accessing the "internet". All Ratis traffic going through the proxy will be a serious bottleneck. CC @szetszwo |
I'm not sure about the use case for http proxy for the detected error case. I can think of HttpFS where client wants to set up a proxy to route all requests through it. Is it a valid case? In this case how can we route only selective traffic through proxy |
|
I mean we should change Ratis to ignore any HTTP proxy. It would apply to Ratis client-server traffic, and Ratis server-server traffic. It wouldn't affect traffic from HTTP client to HttpFS server (which doesn't involve Ratis). |
|
Got it. Thanks for explaining. |
|
#1128 is merged. Closing this ... |
netty-proxy-handler artifact is required to handle cases where http proxy is configured in an application .
Currently it is excluded from the misc jar. This caused issues in Ozone -> https://issues.apache.org/jira/browse/HDDS-11257.
https://issues.apache.org/jira/browse/RATIS-2133
Before the fix:
After the fix