[feat][txn] Add TxnID and TransactionCoordinatorClient support to TransactionV5 - #26731
Draft
TomaszGaweda wants to merge 2 commits into
Draft
TomaszGaweda wants to merge 2 commits into
TomaszGaweda wants to merge 2 commits into
Conversation
merlimat
requested changes
Sep 28, 2026
merlimat
left a comment
Contributor
There was a problem hiding this comment.
This was intentionally left out from the v5 API to avoid exposing internals.
I think it would be better to have a discussion on what it's needed instead of exposing the transaction client which is not meant to.
Contributor
Author
|
@merlimat I am open to discussion, can share stream engine developer PoV :) |
Contributor
|
@TomaszGaweda Definitely want to hear you PoV! Can you start a thread on the dev@pulsar.apache.org or a new GitHub discussion to explain what "help" do you need from the client API? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Many streaming engines need to operate on Transaction IDs to deal with exactly-once delivery guarantees.
Previously, in #26646 we've exposed TransactionCoordinatorClient to allow usage in such engines.
This PR does basically the same, but for V5 API, making it ready for streaming engines.
Modifications
Since v5 API does not depend on v4 API, I've copied TxnID and TransactionCoordinatorClient + Exceptions to v5. In PulsarClientV5 I'm returning this wrapped TransactionCoordinatorClient.
TransactionCoordinatorClientV5 just delegates tasks to v4 API, just like most other APIs.
Verifying this change
Every test invoking transactions on V5 API will now test this change.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes