Skip to content

[cleanup] Remove unused config autoShrinkForConsumerPendingAcksMap - #24315

Merged
dao-jun merged 1 commit into
apache:masterfrom
dao-jun:dev/remove_autoShrinkForConsumerPendingAcksMap
May 20, 2025
Merged

dao-jun merged 1 commit into
apache:masterfrom
dao-jun:dev/remove_autoShrinkForConsumerPendingAcksMap

Conversation

@dao-jun

@dao-jun dao-jun commented May 19, 2025

Copy link
Copy Markdown
Member

Motivation

The config was introduced by #14515
and deprecated by https://github.com/apache/pulsar/pull/23352/files#diff-6bdf62fdf16d74a56f5f9c1f5a6bf30f4360ad7022c69ab8f90c90a267bc568e

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@dao-jun
dao-jun requested review from lhotari and nodece May 19, 2025 03:46
@dao-jun dao-jun self-assigned this May 19, 2025
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label May 19, 2025
@thetumbled

Copy link
Copy Markdown
Member

I wonder whether a pip is required for configuration change.

@thetumbled thetumbled left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dao-jun dao-jun changed the title Remove unused config autoShrinkForConsumerPendingAcksMap [cleanup] Remove unused config autoShrinkForConsumerPendingAcksMap May 19, 2025
@codecov-commenter

codecov-commenter commented May 19, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23%. Comparing base (bbc6224) to head (31df7f4).
Report is 1107 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24315      +/-   ##
============================================
+ Coverage     73.57%   74.23%   +0.66%     
+ Complexity    32624    32258     -366     
============================================
  Files          1877     1866      -11     
  Lines        139502   145100    +5598     
  Branches      15299    16591    +1292     
============================================
+ Hits         102638   107721    +5083     
+ Misses        28908    28863      -45     
- Partials       7956     8516     +560     
Flag Coverage Δ
inttests 26.64% <ø> (+2.06%) ⬆️
systests 23.24% <ø> (-1.08%) ⬇️
unittests 73.73% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 98.16% <ø> (-1.24%) ⬇️

... and 1082 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dao-jun

dao-jun commented May 20, 2025

Copy link
Copy Markdown
Member Author

I wonder whether a pip is required for configuration change.

Seems not, there were some PRs to remove used config without PIP

@dao-jun
dao-jun merged commit 610060e into apache:master May 20, 2025
@dao-jun
dao-jun deleted the dev/remove_autoShrinkForConsumerPendingAcksMap branch May 20, 2025 06:38
@lhotari lhotari added this to the 4.1.0 milestone May 20, 2025
lhotari pushed a commit that referenced this pull request May 20, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 28, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 2, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants