Skip to content

[fix][ml] Fix race conditions in RangeCache #22789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 7 commits into from
May 31, 2024
Merged

[fix][ml] Fix race conditions in RangeCache #22789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88f34bb
[fix][ml] Fix race conditions in RangeCache
lhotari May 28, 2024
172de16
Refactor RangeCache and cover yet another race condition
lhotari May 30, 2024
94101c7
Add javadoc, add refCnt check
lhotari May 30, 2024
d28db55
Handle the race condition where the IdentityWrapper has already been …
lhotari May 30, 2024
b0f3473
Remove synchronization from the clear method since it's not needed an…
lhotari May 30, 2024
56c5823
Add javadoc
lhotari May 30, 2024
2a6c2b1
Improve the current race condition test for put method
lhotari May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@
import org.apache.bookkeeper.client.api.LedgerEntry;
import org.apache.bookkeeper.mledger.Entry;
import org.apache.bookkeeper.mledger.util.AbstractCASReferenceCounted;
import org.apache.bookkeeper.mledger.util.RangeCache;

public final class EntryImpl extends AbstractCASReferenceCounted implements Entry, Comparable<EntryImpl>,
ReferenceCounted {
RangeCache.ValueWithKeyValidation<PositionImpl> {

private static final Recycler<EntryImpl> RECYCLER = new Recycler<EntryImpl>() {
@Override
Expand Down Expand Up @@ -205,4 +206,8 @@ protected void deallocate() {
recyclerHandle.recycle(this);
}

@Override
public boolean matchesKey(PositionImpl key) {
return key.compareTo(ledgerId, entryId) == 0;
}
}
Loading