Fix retry handling in executeSelect() - #5501
Open
dimas-b wants to merge 1 commit into
Open
Conversation
dimas-b
force-pushed
the
fix-select-retries
branch
2 times, most recently
from
September 11, 2026 19:41
df88417 to
a890feb
Compare
Do not accumulate result entries across retries. Convert each result set stream into a fresh list of results. Fixes apache#5498
dimas-b
force-pushed
the
fix-select-retries
branch
from
September 11, 2026 19:57
a890feb to
f415b98
Compare
flyrain
approved these changes
Sep 11, 2026
| ArrayList<T> results = new ArrayList<>(); | ||
| executeSelectOverStream(query, converterInstance, stream -> stream.forEach(results::add)); | ||
| return results; | ||
| AtomicReference<List<T>> results = new AtomicReference<>(); |
Contributor
There was a problem hiding this comment.
Nit: it is a local variable, would ArrayList be good enough?
Contributor
Author
There was a problem hiding this comment.
Sorry, @flyrain , what do you mean by "good enough"? Stream.toList() (below) may produce a different List impl. class.
Contributor
There was a problem hiding this comment.
I'm just confirm if AtomicReference is necessary. It is a nit anyway. Feel free to ignore it.
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not accumulate result entries across retries.
Convert each result set stream into a fresh list of results.
Fixes #5498
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)