Preserve external catalog connection fields in Python clients - #5410
Open
mattfaltyn wants to merge 2 commits into
Open
Preserve external catalog connection fields in Python clients#5410mattfaltyn wants to merge 2 commits into
mattfaltyn wants to merge 2 commits into
Conversation
Contributor
|
Hello @mattfaltyn , for spec file change, please start a dev ML for this change. |
Contributor
|
is there a way to resolve it without spec change? |
Contributor
Author
|
Yes. OpenAPI Generator 7.12.0 supports |
flyrain
approved these changes
Sep 3, 2026
flyrain
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @mattfaltyn !
MonkeyCanCode
approved these changes
Sep 3, 2026
Contributor
|
LGTM @mattfaltyn . Mind fix the conflict when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated Python management client currently loses subtype-specific connection fields for Iceberg REST, Hadoop, and Hive external catalogs. OpenAPI Generator does not merge schema properties declared as siblings of
allOfby default, soConnectionConfigInfo.from_dict()discardsremoteCatalogNameandwarehouse;polaris setup exportthen writes those fields asnull.This change:
REFACTOR_ALLOF_WITH_PROPERTIES_ONLYnormalizer for Python management-client generation, leaving the source OpenAPI specification unchanged;The wire contract, source OpenAPI specification, and requiredness are unchanged; this corrects generated-client model composition.
Fixes #5409
Validation
make client-regeneratemake client-unit-test— 198 passedmake client-lintmake client-license-checkmake client-build./gradlew format compileAllwith Java 21AI assistance
AI assistance was used for investigation, reproduction, implementation, and validation. I reviewed the issue, generated diff, tests, and contribution text and understand the change end to end.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(not needed; the API contract and usage are unchanged)