CLI: Setup AWS missing parameters during setup/export - #5219
Merged
MonkeyCanCode merged 2 commits intoAug 4, 2026
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the two missing fields (endpoint_internal and sts_endpoint) that got loss during setup apply/export. As we are using an valid S3 endpoint value ("https://s3.us-west-2.amazonaws.com") in
site/content/guides/assets/polaris/reference-setup-config.yaml, I am setting endpoint_internal to "https://bucket.vpce-1a2b3c4d-5e6f.s3.us-west-2.vpce.amazonaws.com" (sample value obtained from https://docs.aws.amazon.com/AmazonS3/latest/userguide/privatelink-interface-endpoints.html but with region change from us-east-1 to us-west-2 for consistency).Also, I added a test in
test_catalogs_command.pyto cover S3/STS endpoints are optional and they are are getting process correctly. The fall-back logic for sts_endpoint is not covered here as those are covered on the server side (but I added a comment insite/content/guides/assets/polaris/reference-setup-config.yamlto mention how the fall-back works).Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)