Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19542 +/- ##
============================================
+ Coverage 67.72% 67.78% +0.06%
Complexity 1450 1450
============================================
Files 3490 3491 +1
Lines 225032 225095 +63
Branches 35527 35538 +11
============================================
+ Hits 152393 152576 +183
+ Misses 60612 60463 -149
- Partials 12027 12056 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External query execution cannot call Pinot's cooperative Java accounting checkpoints while its query thread is outside Java. Calling the existing checkpoint from a monitor instead samples the monitor thread, and blocking the shared monitor to honor a pause prevents it from observing resume requests.
This adds an optional, owner-bound
ExternalExecutionSamplertoThreadAccountant. Supported accountants publish the original platform query thread's CPU and JVM allocation deltas into the existing tracker and expose a nonblocking pause observation. Closing the scope on the owner drains in-flight sampling before the query context is cleared.Compatibility and scope
null. Unsupported accountants and custom subclasses must explicitly implement their policy before external execution can use them; callers must retain Java checkpoints or reject that execution path when capture returnsnull.Integration example
Capture after opening the query's accounting context, on the thread that will execute external work. The example below is schematic:
sharedMonitor,registration, andcontrolare supplied by the consuming engine; closing the registration must unregister and drain its callback.The monitor must keep observing while execution is paused so it can forward resume requests. Sampling failures must stop execution and propagate to the query. The consuming engine remains responsible for deadlines, cancellation, and its own allocation budget. Do not independently sample/reset/clear the owning accountant while this scope is active. The same lifecycle is documented on
ExternalExecutionSampler.Validation
JDK 25:
All 16 selected reactor modules succeeded. All 9 new tests passed (3 SPI, 6 core), covering original-thread CPU/allocation attribution, final accounting cleanup, real pause/resume state, draining and owner-only close, and unsupported/custom/virtual/foreign-context rejection. These tests exercise the Java management counters and lifecycle; they do not benchmark or validate an external engine.
Affected-module Spotless, Checkstyle, license checks, and warning-enabled
test-compilepassed. The compiler emitted no warnings for the changed classes.The additional warning-enabled reactor
test-compilecheck stops in unchangedpinot-segment-localcode atZstandardDecompressor.java:51becauseorg.jetbrains.annotations.NotNullis unavailable. This does not affect the successful normal reactor install/test run above.