PARQUET-2344: Bump to Thrift 0.19.0#1192
Conversation
0136c22 to
ccd3f94
Compare
parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftTypeID.java
Show resolved
Hide resolved
|
Do you need any additional fix to parquet-format before the v2.10 release? @Fokko |
|
@wgtmac No just the release, thanks for asking :) |
Thanks for confirmation! |
|
@Fokko Do you want to include parquet-format 2.10.0 adoption in this PR or create a separate one? IMO, there are several PRs waiting for 2.10.0 to rebase so it would be good to check that in first? |
9d29b90 to
264b859
Compare
|
@wgtmac Thanks for splitting out the format upgrade. Always a good idea to make PRs smaller. I finally fixed all the tests, and this looks good to go to me 👍 |
a9950e7 to
41c0d26
Compare
| List<EnumValue> values = new ArrayList<ThriftType.EnumValue>(); | ||
| for (TEnum tEnum : enumValues) { | ||
| values.add(new EnumValue(tEnum.getValue(), tEnum.toString())); | ||
| if (field.isEnum()) { |
There was a problem hiding this comment.
Why mixing UUID and ENUM in this case?
There was a problem hiding this comment.
It looks like there are still enums with field-id 16. It can be that they are using an old Java SDK. This was a reliable way do differentiate between them.
| <failOnWarning>true</failOnWarning> | ||
| <ignoreNonCompile>true</ignoreNonCompile> | ||
| <ignoredDependencies> | ||
| <dependency>javax.annotation:javax.annotation-api:jar:1.3.2</dependency> |
| </dependency> | ||
| <dependency> | ||
| <groupId>javax.annotation</groupId> | ||
| <artifactId>javax.annotation-api</artifactId> |
parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftTypeID.java
Show resolved
Hide resolved
|
Do you want to merge this? |
|
@wgtmac Yes, I'd love to. Thanks 🙌 |
Make sure you have checked all steps below.
This requires a new release of
parquet-format, but it looks like @wgtmac is on top of that: apache/parquet-format#197 (comment)Jira
Tests
Commits
Documentation