MINOR: Fix formatting in parquet.thrift file (trailing spaces)#558
Conversation
There were many trailing spaces here and there, they have been removed. Signed-off-by: OmBiradar <ombiradar04@gmail.com>
parquet.thrift file (trailing spaces)parquet.thrift file (trailing spaces)
|
original issue - apache-arrow-issue-49501 requesting your review @alamb |
alamb
left a comment
There was a problem hiding this comment.
THis is a nice cleanup in my opinion
Thank you @OmBiradar
|
(I'll leave this open for a while to make sure other committers have a chance to review if they would like) |
wgtmac
left a comment
There was a problem hiding this comment.
+1 from me. I know the intention is good but I don't know if anyone really cares about the original commit history.
The commit history will be retained, but just using |
|
What if we add a new '.git-blame-ignore-revs' file that will help avoid these formatting/linting related commits to interfear with the 'git blame' |
|
| 1: optional binary max; | ||
| 2: optional binary min; | ||
| /** | ||
| /** |
There was a problem hiding this comment.
using git blame -w does indeed correctly ignore whitespace differences:
git blame -w src/main/thrift/parquet.thrift
...
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17 18:21:15 -0700 267) struct Statistics {
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 268) /**
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 269) * DEPRECATED: min and max value of the column. Use min_value and max_value.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 270) *
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 271) * Values are encoded using PLAIN encoding, except that variable-length byte
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 272) * arrays do not include a length prefix.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 273) *
bef54389 src/main/thrift/parquet.thrift (Zoltan Ivanfi 2017-10-06 16:38:53 -0700 274) * These fields encode min and max values determined by signed comparison
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 275) * only. New files should use the correct order for a column's logical type
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 276) * and store the values in the min_value and max_value fields.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 277) *
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 278) * To support older readers, these may be set when the column order is
bef54389 src/main/thrift/parquet.thrift (Zoltan Ivanfi 2017-10-06 16:38:53 -0700 279) * signed.
041708da src/main/thrift/parquet.thrift (Ryan Blue 2017-04-17 11:23:41 -0700 280) */
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17 18:21:15 -0700 281) 1: optional binary max;
2c4ada8e src/thrift/parquet.thrift (julien 2013-09-17 18:21:15 -0700 282) 2: optional binary min;
db687874 src/main/thrift/parquet.thrift (mwish 2024-08-23 15:30:20 +0800 283) /**
db687874 src/main/thrift/parquet.thrift (mwish 2024-08-23 15:30:20 +0800 284) * Count of null values in the column.|
Thanks again for the help cleaning this up @OmBiradar |
There were many trailing spaces here and there,
they have been removed.
Rationale for this change
Used the zed editors linter to format the document - removing any trailing spaces.
What changes are included in this PR?
Just removed the trailing spaces.